Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node to machine additionalPrinterColumns #365

Closed
wants to merge 1 commit into from
Closed

Add node to machine additionalPrinterColumns #365

wants to merge 1 commit into from

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Jul 29, 2019

Add node to machine additionalPrinterColumns

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign enxebre
You can assign the PR to them by writing /assign @enxebre in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 29, 2019
@openshift-ci-robot
Copy link
Contributor

@enxebre: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-operator 4128f1b link /test e2e-aws-operator

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ingvagabund
ingvagabund requested changes Jul 30, 2019
View reviewed changes
install/0000_30_machine-api-operator_02_machine.crd.yaml
@@ -27,6 +27,10 @@ spec:
description: Zone associated with machine
name: Zone
type: string
- JSONPath: .status.nodeRef.name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be set in machine_types.go first and the CRD updated by running make gen-crd. Otherwise, your change will get removed after the CRD gets regen again. Let's collect all the bits in openshift/cluster-api#55 first.

@ingvagabund
Copy link
Member

Part of #360

@ingvagabund ingvagabund closed this Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund ingvagabund requested changes

@bison bison Awaiting requested review from bison

@michaelgugino michaelgugino Awaiting requested review from michaelgugino

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enxebre @openshift-ci-robot @ingvagabund