Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug 1740004: Set additional machine annotations/labels to get pretty machine output #48

Merged
merged 1 commit into from
Aug 20, 2019
Merged

bug 1740004: Set additional machine annotations/labels to get pretty machine output #48

merged 1 commit into from
Aug 20, 2019

Conversation

ingvagabund
Copy link
Member

Set common machine fields so when a machine provisioned in Azure is listed through oc get machines
all additional printer colums are properly populated. E.g. region, zone, instance type.

NAME                     STATE     TYPE            REGION  	 ZONE            AGE
jchalo-pm2hk-m-0         RUNNING   n1-standard-4   us-central1   us-central1-a   20h
jchalo-pm2hk-m-1         RUNNING   n1-standard-4   us-central1   us-central1-b   20h
jchalo-pm2hk-m-2         RUNNING   n1-standard-4   us-central1   us-central1-c   20h
jchalo-pm2hk-w-a-wfrmf   RUNNING   n1-standard-4   us-central1   us-central1-a   20h
jchalo-pm2hk-w-b-l2wv5   RUNNING   n1-standard-4   us-central1   us-central1-b   20h
jchalo-pm2hk-w-c-fvh4h   RUNNING   n1-standard-4   us-central1   us-central1-c   20h

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 20, 2019
@ingvagabund ingvagabund mentioned this pull request Aug 20, 2019
Merged
4 tasks
@ingvagabund ingvagabund changed the title WIP: Set additional machine annotations/labels to get pretty machine output Set additional machine annotations/labels to get pretty machine output Aug 20, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2019
@ingvagabund ingvagabund changed the title Set additional machine annotations/labels to get pretty machine output bug 1740004: Set additional machine annotations/labels to get pretty machine output Aug 20, 2019
@openshift-ci-robot
Copy link
Contributor

@ingvagabund: This pull request references Bugzilla bug 1740004, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

bug 1740004: Set additional machine annotations/labels to get pretty machine output

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 20, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 20, 2019
@ingvagabund
WIP: Set additional machine annotations/labels to get pretty machine …
b767097 
…output

Set common machine fields so when a machine provisioned in Azure is listed through oc get machines
all additional printer colums are properly populated. E.g. region, zone, instance type.

```
NAME                     STATE     TYPE            REGION  	 ZONE            AGE
jchalo-pm2hk-m-0         RUNNING   n1-standard-4   us-central1   us-central1-a   20h
jchalo-pm2hk-m-1         RUNNING   n1-standard-4   us-central1   us-central1-b   20h
jchalo-pm2hk-m-2         RUNNING   n1-standard-4   us-central1   us-central1-c   20h
jchalo-pm2hk-w-a-wfrmf   RUNNING   n1-standard-4   us-central1   us-central1-a   20h
jchalo-pm2hk-w-b-l2wv5   RUNNING   n1-standard-4   us-central1   us-central1-b   20h
jchalo-pm2hk-w-c-fvh4h   RUNNING   n1-standard-4   us-central1   us-central1-c   20h
```
bison
bison approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2019
@vikaschoudhary16
Copy link

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vikaschoudhary16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2019
@openshift-merge-robot openshift-merge-robot merged commit b8e87a6 into openshift:master Aug 20, 2019
@openshift-ci-robot
Copy link
Contributor

@ingvagabund: All pull requests linked via external trackers have merged. Bugzilla bug 1740004 has been moved to the MODIFIED state.

In response to this:

bug 1740004: Set additional machine annotations/labels to get pretty machine output

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund deleted the label-annotation-machines branch August 20, 2019 12:10
@openshift-ci-robot
Copy link
Contributor

@ingvagabund: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-operator b767097 link /test e2e-gcp-operator

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

RadekManak pushed a commit to RadekManak/cluster-api-provider-gcp that referenced this pull request Apr 12, 2023
@k8s-ci-robot
Merge pull request openshift#48 from miyadav/patch-1
f6387a1 
📖 Update capi-operator-proposal.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bison bison bison approved these changes

@michaelgugino michaelgugino Awaiting requested review from michaelgugino

Assignees

@bison bison

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ingvagabund @openshift-ci-robot @vikaschoudhary16 @bison @openshift-merge-robot