-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug 1740004: Set additional machine annotations/labels to get pretty machine output #48
bug 1740004: Set additional machine annotations/labels to get pretty machine output #48
Conversation
@ingvagabund: This pull request references Bugzilla bug 1740004, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8934b22
to
9bf9df0
Compare
9bf9df0
to
8ee9f5c
Compare
…output Set common machine fields so when a machine provisioned in Azure is listed through oc get machines all additional printer colums are properly populated. E.g. region, zone, instance type. ``` NAME STATE TYPE REGION ZONE AGE jchalo-pm2hk-m-0 RUNNING n1-standard-4 us-central1 us-central1-a 20h jchalo-pm2hk-m-1 RUNNING n1-standard-4 us-central1 us-central1-b 20h jchalo-pm2hk-m-2 RUNNING n1-standard-4 us-central1 us-central1-c 20h jchalo-pm2hk-w-a-wfrmf RUNNING n1-standard-4 us-central1 us-central1-a 20h jchalo-pm2hk-w-b-l2wv5 RUNNING n1-standard-4 us-central1 us-central1-b 20h jchalo-pm2hk-w-c-fvh4h RUNNING n1-standard-4 us-central1 us-central1-c 20h ```
8ee9f5c
to
b767097
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vikaschoudhary16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ingvagabund: All pull requests linked via external trackers have merged. Bugzilla bug 1740004 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ingvagabund: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
📖 Update capi-operator-proposal.md
Set common machine fields so when a machine provisioned in Azure is listed through oc get machines
all additional printer colums are properly populated. E.g. region, zone, instance type.