Core group can be used as "" or "core" but deduplication doesn't take that into account

[pmalek]

Problem statement

0.16.0 introduced deduplication in #937.

Since core can be referred to by "" or "core" this should be taken into account but it isn't causing 2 apigroups to be added for the same core group.

How to reproduce

Have 2 different but logically identical codemarkers:

//+kubebuilder:rbac:groups=core,resources=events,verbs=create;patch

and

// +kubebuilder:rbac:groups="",resources=events,verbs=create;patch

Get the following generated with 0.16.1:

rules:
- apiGroups:
  - ""
  - ""
  resources:
  - events
  verbs:
  - create
  - patch

The workaround is to use the same apigroup everywhere.

[sbueringer]

Thx!

/help

[k8s-ci-robot]

@sbueringer:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Thx!

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[chrischdi]

/assign