Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 rbac: fix deduplication of core group and add test coverage #1045

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

chrischdi
Copy link
Member

Fixes: #1036

Deduplication happened before renaming.

Now renaming before doing deduplication to fix this case for the core group.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 29, 2024
pkg/rbac/parser.go Outdated Show resolved Hide resolved
@chrischdi
Copy link
Member Author

/test pull-controller-tools-test-master

Dunno why it did not run

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-controller-tools-test-main

Use /test all to run all jobs.

In response to this:

/test pull-controller-tools-test-master

Dunno why it did not run

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Member Author

/test pull-controller-tools-test-master

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-controller-tools-test-main

Use /test all to run all jobs.

In response to this:

/test pull-controller-tools-test-master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi chrischdi changed the title 🐛 rbac: fix deduplication of core group and add test coverage 🌱 rbac: fix deduplication of core group and add test coverage Aug 29, 2024
@chrischdi
Copy link
Member Author

weird, why is there a pull-controller-tools-test-master, I guess it was moved to main during the pr

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 29, 2024
@sbueringer sbueringer changed the title 🌱 rbac: fix deduplication of core group and add test coverage 🐛 rbac: fix deduplication of core group and add test coverage Aug 29, 2024
@sbueringer
Copy link
Member

Thank you very much!!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 73582574176256678d0b4379c9e391f5db1cfb43

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 11f0724 into kubernetes-sigs:main Aug 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core group can be used as "" or "core" but deduplication doesn't take that into account
3 participants