-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single-version generated CRDs cannot be installed #302
Comments
Just tested it with k8s 1.14.5. The creation command succeeds but all validations are omitted. The yaml file I use for creation:
What I get when I run
|
It still doesn't pass because validations in new CRD format that controller-tools 0.2.0 generates are ignored, hence validation tests fail. See kubernetes-sigs/controller-tools#302 (comment) Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
It still doesn't pass because validations in new CRD format that controller-tools 0.2.0 generates are ignored, hence validation tests fail. See kubernetes-sigs/controller-tools#302 (comment) Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
I think it's been fixed by #322 |
Interestingly enough, i see this problem only when testing my controller with
|
Here's a sample with |
@muvaf my workaround is to not install the CRDs with With that said, I'm thinking the problem lies in |
@pires Thanks for the suggestion! I haven't run into this issue since we haven't needed to migrate to CRD |
You need this in order to enable the generation of certain markers, like |
As per @DirectXMan12 comment, it seems I have no issue at all and this is expected #322 (comment) when doing CRD v1 alone. |
Probably I missed something but I can't get a single-version CRD to be installed on my cluster.
This is a project that has 2 kinds generated by kubebuilder v2: https://github.com/muvaf/kubebuilder-init
Check it out and run the following:
You'll get:
I see that it hits the following error on https://github.com/kubernetes/apiextensions-apiserver/blob/master/pkg/apis/apiextensions/validation/validation.go#L453 which signals it may be a bug on the api-server but I'm not really familiar with that codebase. Any help is appreciated!
Environment:
The text was updated successfully, but these errors were encountered: