-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update controller-tools and CRDs #7634
Conversation
Thanks for doing this. Two things:
|
Thanks for the suggestions! I'm still fighting some dependency version compatibility issues, but the new CRD yamls are looking much better. I'll try to get the remaining issues addressed soon. |
dfe9b32
to
f3a0f0b
Compare
@justinsb reran the go get and everything worked better this time :) CRD diffs are looking good overall too /hold cancel |
Thanks for doing this! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The
make crds
task is currently broken on master because:controller-tools
is no longer in the vendor directory after the switch to go mod. The tools.go addition fixes that.k8s.io/api
and needed updating to the very latest commit in order to pick up support for 1.15.Marking WIP because i haven't had a chance to actually test the CRDs yet and do a structural
yamldiff
to look for any unexpected changes./hold