Official Docker image

[anton-johansson]

Where is the official Docker image located? The job example says descheduler:latest, however, when I try to pull that image I just get:

➜ docker pull descheduler:latest
Error response from daemon: pull access denied for descheduler, repository does not exist or may require 'docker login'

[warmchang]

DIY?

[anton-johansson]

Yeah, I was hoping that we could avoid building and hosting the image ourselves. :(

[aveshagarwal]

@anton-johansson yes we have not pushed official descheduler images. In case you would want to help, you could look into the location/process kubernetes is using to push official images and we could use the same.

[aveshagarwal]

@rhockenbury

[rhockenbury]

It would be great to explore pushing an image to gcr.io, but in the meantime, would it be reasonable to throw the latest image up on dockerhub? - https://hub.docker.com/r/aveshagarwal/descheduler

[aveshagarwal]

@rhockenbury i have pushed 0.9.0 to docker hub: docker.io/aveshagarwal/descheduler:0.9.0

[seanmalloy]

I'm interested in working on this issue. Looks like the official container image would be something like k8s.gcr.io/descheduler:0.9.0. I'll try to research how to get this setup.

[aveshagarwal]

@seanmalloy thanks for working on this issue.

[seanmalloy]

I submitted #160 to get the Makefile updated with an option to push the container images.

[seanmalloy]

The Makefile changes have been merged to master.

I attended the SIG Scheduling meeting today, and it was recommend to reach out to @ravisantoshgudimetla to facilitate getting the official image pushed to k8s.gcr.io.

@ravisantoshgudimetla can you provide any insight on how to push the container image to k8s.gcr.io Or how would we setup an automated process to push the container images k8s.gcr.io?

[seanmalloy]

I submitted PR kubernetes/k8s.io#296 to get the GCR staging repo created.

[rhockenbury]

Is this now waiting on just a new release, and maybe a readme update?

[seanmalloy]

@rhockenbury I believe next steps are ...

Test and merge #173. This will verify that @ravisantoshgudimetla and @aveshagarwal can push to the staging registry.

After that I need to clean up #164, so that the docs are correct. Then a new release would need to be created and the official container image pushed to the production registry.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[seanmalloy]

@aveshagarwal @ravisantoshgudimetla @damemi can one of you remove the lifecycle/stale label from this issue?

[ravisantoshgudimetla]

/remove-lifecycle stale

[seanmalloy]

Now that #173 is merged the descheduler now has an official staging registry in gcr.io that is confirmed to be working.

@ravisantoshgudimetla @aveshagarwal @damemi I'm going to investigate how to get the official production registry setup in gcr.io for the descheduler. I'll let you know what I find out.

[seanmalloy]

I believe I found the relevant documentation for how to make this all happen ...

• https://github.com/kubernetes/k8s.io/blob/master/k8s.gcr.io/README.md
• https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md

It will take me some time to read through the docs and figure out next steps, but I think it is getting pretty close now.

[seanmalloy]

@damemi @ravisantoshgudimetla @aveshagarwal I submitted pull request kubernetes/test-infra#16022 to get a prow job created for automating descheduler container image builds. I believe the only other thing I need to do is get a GCB(Google Cloud Build) config file added to the descheduler repo.

[seanmalloy]

Work in progress PR to add the GCB config #217.

EDIT: The above mentioned PR is no longer a WIP. It is ready for review and merge.

[seanmalloy]

/assign @seanmalloy
/kind feature

[seanmalloy]

Last pull request before I close out this issue ... kubernetes/k8s.io#570.

[seanmalloy]

/close

Starting with the v0.10.0 release the official container image can be downloaded with a command similar to this ...

docker pull us.gcr.io/k8s-artifacts-prod/descheduler/descheduler:v0.10.0

[k8s-ci-robot]

@seanmalloy: Closing this issue.

In response to this:

/close

Starting with the v0.10.0 release the official contain image can be downloaded with a command similar to this ...

docker pull us.gcr.io/k8s-artifacts-prod/descheduler/descheduler:v0.10.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stevehipwell]

Could the documentation be updated to show this? Also is there a plan to have an official Helm chart?

[seanmalloy]

@stevehipwell thanks for the feedback. I'm going to be submitting a PR in a week or two with some more comprehensive documentation for this project. I'll include the container image location in that PR.

Please submit a separate GitHub issue if you think having a helm chart would be a useful feature.

Thanks!