Automate Container Image Builds Using GCB #217
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
This has NOT been tested, so please don't merge it yet. I think right now it will only build the container image, but won't push it. Some tweaks might need to be made to the |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
Adds a GCB(Google Cloud Build) configuraiton file that automates the building and pushing of descheduler container images to the official Google Container Registry for k8s. Reference documentation: https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md
seanmalloy
force-pushed
the
cloud-build-config
branch
from
69914a2 to
3401eda
Compare
|
/hold cancel I made one small change to the GCB config to also push the container image to the staging registry. I believe it will work correctly now. However it is not clear to be how to test the GCB job prior to merging this to the master branch. @damemi @aveshagarwal @ravisantoshgudimetla this is ready for review now. |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/assign @aveshagarwal |
| substitutions: | ||
| # _GIT_TAG will be filled with a git-based tag for the image, of the form vYYYYMMDD-hash, and | ||
| # can be used as a substitution | ||
| _GIT_TAG: '12345' |
There was a problem hiding this comment.
What does this mean? Will this be substituted by the git-tag v20190906-745fed4 ?
There was a problem hiding this comment.
Short answer ...
Yeah it looks like it will be vYYYYMMDD-GIT_TAG. For example v20200131-v0.10.0. I think this is not what we want. When a descheduler version is released the tag should be something like v0.10.0. I'll have to figure out how to change this.
Long answer ...
It looks like this a GCB user defined substitution. The container image listed on line 10 must be going something special with the variable.
I believe I tracked it down to this directory https://github.com/kubernetes/test-infra/tree/master/images/builder. More specifically here ... https://github.com/kubernetes/test-infra/blob/09a81c4adf5b662b2643dccb9d285ad3102af4af/images/builder/main.go#L48-L56.
It seems like most other k8s projects using image build automation are using _GIT_TAG. See here, here and here.
There was a problem hiding this comment.
One more thought ...
We could merge this PR as is and sort out git/docker tag configuration is a follow up PR. This would at least enable the automated builds for the master branch and let us confirm that the build automation is working.
Also be aware that the container build automation only pushes container images the GCR staging registry. A person will still need to submit a pull request for each container image that needs to be promoted to the production GCR registry.
There was a problem hiding this comment.
Another thought (which is where the design comes from): it doesn't really matter what you tag things in the staging registry - when the image promoter promotes them, they can be given a different tag to what they had in staging.
There was a problem hiding this comment.
@Katharine thanks for adding your comment. This makes sense to me now. We don't need to worry about the tags in the staging registry.
@ravisantoshgudimetla let me know if you have any additional questions on this topic.
There was a problem hiding this comment.
So, with this as it is we'll get staging repo tags in the format v20190906-v0.9.0-76-g30d05382b (based on my own run of the function you linked to here).
That seems good enough for me in the staging repo, it's descriptive of the version. And we choose our published tag when promoted, so it will be cleaner (like v0.9.0). Sgtm
|
/hold I need to add some basic docs explaining how this works for both the automated and manual process. |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
size/M
|
/hold cancel I added commit ac089fe to this pull request that documents the new release process. This PR is now ready for review. @ravisantoshgudimetla @aveshagarwal and @damemi please review this commit to make sure the release documentation is clear. Thanks! |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@seanmalloy thanks for this work, this all looks good to me. The instructions you linked are pretty clear and are definitely helpful to add. |
k8s-ci-robot
added
the
lgtm
|
@seanmalloy - Thanks for working on this. /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ravisantoshgudimetla, seanmalloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…ld-config Automate Container Image Builds Using GCB
Adds a GCB(Google Cloud Build) configuraiton file that automates the
building and pushing of descheduler container images to the official
Google Container Registry for k8s.
Reference documentation:
https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md