Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.10.0 #224

Closed
6 tasks done
seanmalloy opened this issue Feb 1, 2020 · 24 comments
Closed
6 tasks done

Release v0.10.0 #224

seanmalloy opened this issue Feb 1, 2020 · 24 comments

Comments

@seanmalloy
Copy link
Member

seanmalloy commented Feb 1, 2020

It has been quite a while since the last scheduler release. I am proposing that descheduler release v0.10.0 is created in the near future. See below list of suggested pull requests that I think should be merged before the v0.10.0 release is created.

Additionally this would be the first release where an official container image for descheduler can be pushed to gcr.io.

Normally I would create a milestone for tracking this stuff, but I don't have access to create/update milestones in the repo. So this is the best alternative I could come up with.

@seanmalloy
Copy link
Member Author

@ravisantoshgudimetla @aveshagarwal @damemi let me know if you think this is a reasonable proposal.

Also ...

I think I can help out by reviewing #216 in the near future and I will also sign up for writing the release notes for v0.10.0. Let me know if there is anything else I could do to help with this.

@damemi
Copy link
Contributor

damemi commented Feb 1, 2020

Thanks @seanmalloy, definitely +1 to this.

It would also be nice if we could start tagging regular releases to coincide with our bumps for kubernetes versions. Maybe even use a matching version scheme like v0.10.18->k8s 1.18, etc.

@seanmalloy
Copy link
Member Author

seanmalloy commented Feb 2, 2020

Rough draft of release notes. I'll probably review and revise these at least one more time myself, but if anyone else has any suggestions that would be cool too.

New Features 🌈

Bug Fixes 🐛

Others 🏃

@damemi
Copy link
Contributor

damemi commented Feb 3, 2020

These release notes look good. #221 just merged so you can add that to the notes and cross it off in your original post. I'd like to get everything else in your first post finished too, hopefully before the 1.18 release of k/k

@aveshagarwal
Copy link
Contributor

@seanmalloy release notes looks really good. thanks.

@ravisantoshgudimetla
Copy link
Contributor

I agree with @damemi and @aveshagarwal on the release notes. This is really good. Thanks for working on this @seanmalloy

@seanmalloy
Copy link
Member Author

Just one more PR to review and merge for the v0.10.0 release, #208.

Here is a gist with the updated release notes. This should provide an easy copy and paste for the person that creates the release.

https://gist.github.com/seanmalloy/3ae02ebdad8519db0d2dddb3f36bb471

@aveshagarwal
Copy link
Contributor

thanks a lot @seanmalloy and @damemi for your work on this release.

Would like to know your thoughts what you think if instead of making 0.10.0, we release 1.0.0?

@damemi
Copy link
Contributor

damemi commented Feb 7, 2020

I would like to get this to 1.0.0 as soon as we can, but I think we should first promote our APIs out of alpha before bumping to a major version release. Wdyt?

@seanmalloy
Copy link
Member Author

I agree with @damemi. We have a some work to do before we are ready for v1.0.0. I think for now it would be best to stick with v0.10.0.

@aveshagarwal
Copy link
Contributor

ok sounds good. Please let me know if we are ready and i will cut a release v0.10.0.

@aveshagarwal
Copy link
Contributor

would like to get this PR: #236 in before we cut a release.

@seanmalloy
Copy link
Member Author

@aveshagarwal I'm not aware of anything else that needs to be merged prior to cutting the release. Let me know if you need any help with the release process.

@aveshagarwal
Copy link
Contributor

aveshagarwal commented Feb 12, 2020

@seanmalloy as per the release process doc and semi auto section, i have completed first 3 steps. Feel free to go for other steps. Let me know if my help is needed.

@seanmalloy
Copy link
Member Author

@aveshagarwal here is the PR for step 4 ... kubernetes/k8s.io#570.

@aveshagarwal
Copy link
Contributor

@aveshagarwal here is the PR for step 4 ... kubernetes/k8s.io#570.

i have lgtm'ed, i am not sure if i can /approve too in that repo.

@seanmalloy
Copy link
Member Author

i have lgtm'ed, i am not sure if i can /approve too in that repo.

@aveshagarwal you have been added to the OWNERS file here, so for future releases both you and @ravisantoshgudimetla will be able to approve descheduler image promotions.

Step 4 is done the image is available at us.gcr.io/k8s-artifacts-prod/descheduler/descheduler:v0.10.0.

@aveshagarwal you can go ahead and complete the last two release steps, 5 and 6.

@aveshagarwal
Copy link
Contributor

aveshagarwal commented Feb 20, 2020

@seanmalloy thanks a lot for your help. I have published v0.10.0 now so step 5 is done now. Feel free to go for step 6.

@seanmalloy
Copy link
Member Author

seanmalloy commented Feb 20, 2020

@aveshagarwal I'll do the 6th and final step. Thanks for your help!

@mattlqx
Copy link

mattlqx commented Feb 20, 2020

FYI the release notes at https://github.com/kubernetes-sigs/descheduler/releases are incorrect as they state the image as us.gcr.io/k8s-artifacts-prod/descheduler:v0.10.0 and not us.gcr.io/k8s-artifacts-prod/descheduler/descheduler:v0.10.0.

@seanmalloy
Copy link
Member Author

@aveshagarwal I had the incorrect image location in the release notes. Sorry about this. Can you edit the release notes to change the location of the container image to be us.gcr.io/k8s-artifacts-prod/descheduler/descheduler:v0.10.0?

https://github.com/kubernetes-sigs/descheduler/releases/tag/v0.10.0

I completed step 6(send email). I'll close out this issue once the typo is fixed in the release notes.

@aveshagarwal
Copy link
Contributor

@seanmalloy fixed the path.

@seanmalloy
Copy link
Member Author

/close

Thanks for your help @aveshagarwal!

@k8s-ci-robot
Copy link
Contributor

@seanmalloy: Closing this issue.

In response to this:

/close

Thanks for your help @aveshagarwal!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants