Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded node selection in E2e test #169

Merged
merged 2 commits into from
Jul 12, 2019
Merged

Remove hardcoded node selection in E2e test #169

merged 2 commits into from
Jul 12, 2019

Conversation

Bowenislandsong
Copy link
Contributor

/kind flake

The e2e test was hardcoded to selecting the 3rd node as default leastLoadedNode. This hard coding does not guarantee to select the least loaded node if the testing cluster is set up differently.

Fixes # This fix help selects the actual least loaded node based on the number of pods assigned to each node after RC is set up. It also skips the master node.

/cc @ravisantoshgudimetla

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 11, 2019
Change hard coded leastLoadedNode=[3rd node] to searching for leastLo…
7245a31 
…adedNode worker node

Accomodate kubernetes-sigs@dee89a6

And format files according to gofmt verification

update version to 1.11.1
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 11, 2019
ravisantoshgudimetla
ravisantoshgudimetla approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the @Bowenislandsong . Can you check if the pods are actually getting evicted if tested locally? Meaning can you manually increase the log level and verify that pods are getting evicted?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2019
@Bowenislandsong
Copy link
Contributor Author

/lgtm

Thanks for the @Bowenislandsong . Can you check if the pods are actually getting evicted if tested locally? Meaning can you manually increase the log level and verify that pods are getting evicted?

I did check by stepping through the code in debug mode, I will run the test again in a bit by showing the logging. Thank you.

@Bowenislandsong
Copy link
Contributor Author

We expect the number of pods on the least utilized node to be 7 before eviction test and 8 after.

ravisantoshgudimetla
ravisantoshgudimetla approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks for the PR :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ravisantoshgudimetla]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9e28f0b into kubernetes-sigs:master Jul 12, 2019
@ingvagabund ingvagabund mentioned this pull request Sep 12, 2019
Merged
@seanmalloy seanmalloy mentioned this pull request Feb 2, 2020
Closed
6 tasks
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Merge pull request kubernetes-sigs#169 from Bowenislandsong/fix-test
d5cfe62 
Remove hardcoded node selection in E2e test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravisantoshgudimetla ravisantoshgudimetla ravisantoshgudimetla approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bowenislandsong @k8s-ci-robot @ravisantoshgudimetla