Add verify scripts for make gen

[damemi]

Issues such as the one described in #482 could be avoided if we add automatic verify scripts on PRs to ensure that make gen (and its subscripts) have been run. It should be simple enough as running make gen in a tmp dir and checking if any changes have been generated.

/kind cleanup
/help

[k8s-ci-robot]

@damemi:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Issues such as the one described in #482 could be avoided if we add automatic verify scripts on PRs to ensure that make gen (and its subscripts) have been run. It should be simple enough as running make gen in a tmp dir and checking if any changes have been generated.

/kind cleanup
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pravarag]

@damemi I would like to work on this issue if it's not already been taken :)

/assign

[pravarag]

@damemi I've come across few doubts while trying to understand the issue. As you mentioned that we need this change to ensure make gen has run it's all subscripts proprerly and when I try to run make gen locally, it basically generates three binaries,

conversion-gen
deepcopy-gen
defaulter-gen

So, do we need to ensure that make gen has generated those three binaries in /tmp location properly or not?

[damemi]

Those binaries are what actually run to generate the updated code. make gen conveniently downloads them (if they do not already exist) and stores them in the tmp directory which is ignored by git.

The goal here is to make sure that code which is about to be committed has already run these generators. What we want to check is that the diff in a PR doesn't change when you run make gen against it.

So, since the binaries themselves are not committed we can't check that they are stored in /tmp (but if they aren't being downloaded, then the generators won't be running anyway, so you will still see a diff).

[seanmalloy]

Not quite done yet.

/reopen

[k8s-ci-robot]

@seanmalloy: Reopened this issue.

In response to this:

Not quite done yet.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pravarag]

@seanmalloy @damemi is it okay to close this issue now? The last PR for defaulters gen has been merged today. Let me know if there is anything else I need to check w.r.t this issue.

[seanmalloy]

I believe everything is done now. @pravarag thanks for your help with this!

/close

[k8s-ci-robot]

@seanmalloy: Closing this issue.

In response to this:

I believe everything is done now. @pravarag thanks for your help with this!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.