Add verify scripts for defaulters generator

[pravarag]

This PR is related to: #483

This PR contains changes for verifying defaulters generator. Currently I'm facing a SIGSEGV error while trying to run verify-defaulters.sh script from local with below logs,

-bash>descheduler(verify-defaulters-gen)$
 ->  ./hack/verify-defaulters.sh
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x68 pc=0x12b69a7]

goroutine 1 [running]:
k8s.io/gengo/examples/defaulter-gen/generators.getManualDefaultingFunctions(0xc0080d6540, 0x0, 0xc009de99e0)
	/Users/pravaragrawal/Work/go_work/src/github.com/pravarag/descheduler/_tmp/kube-verify.u8W7BZ/descheduler/vendor/k8s.io/gengo/examples/defaulter-gen/generators/defaulter.go:149 +0xa7
k8s.io/gengo/examples/defaulter-gen/generators.Packages(0xc0080d6540, 0xc000132e60, 0x1353d49, 0x6, 0xc0080d6540)
	/Users/pravaragrawal/Work/go_work/src/github.com/pravarag/descheduler/_tmp/kube-verify.u8W7BZ/descheduler/vendor/k8s.io/gengo/examples/defaulter-gen/generators/defaulter.go:275 +0x79f
k8s.io/gengo/args.(*GeneratorArgs).Execute(0xc000132e60, 0xc000103050, 0x1353d49, 0x6, 0x1381050, 0x0, 0x0)
	/Users/pravaragrawal/Work/go_work/src/github.com/pravarag/descheduler/_tmp/kube-verify.u8W7BZ/descheduler/vendor/k8s.io/gengo/args/args.go:206 +0x1b7
main.main()
	/Users/pravaragrawal/Work/go_work/src/github.com/pravarag/descheduler/_tmp/kube-verify.u8W7BZ/descheduler/vendor/k8s.io/code-generator/cmd/defaulter-gen/main.go:76 +0x365

Opening this PR as a follow-up from this conversation: #507 (comment)

[k8s-ci-robot]

Hi @pravarag. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ingvagabund]

/ok-to-test

[ingvagabund]

/retest

[ingvagabund]

@pravarag the test is still failing with:

./hack/verify-defaulters.sh
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x68 pc=0x6b3ba7]
goroutine 1 [running]:
k8s.io/gengo/examples/defaulter-gen/generators.getManualDefaultingFunctions(0xc0052a0700, 0x0, 0xc00af8f860)
	/home/prow/go/src/sigs.k8s.io/descheduler/_tmp/kube-verify.1BwmFC/descheduler/vendor/k8s.io/gengo/examples/defaulter-gen/generators/defaulter.go:149 +0xa7
k8s.io/gengo/examples/defaulter-gen/generators.Packages(0xc0052a0700, 0xc000118e60, 0x74fc51, 0x6, 0xc0052a0700)
	/home/prow/go/src/sigs.k8s.io/descheduler/_tmp/kube-verify.1BwmFC/descheduler/vendor/k8s.io/gengo/examples/defaulter-gen/generators/defaulter.go:275 +0x79f
k8s.io/gengo/args.(*GeneratorArgs).Execute(0xc000118e60, 0xc00007d020, 0x74fc51, 0x6, 0x77d430, 0x0, 0x0)
	/home/prow/go/src/sigs.k8s.io/descheduler/_tmp/kube-verify.1BwmFC/descheduler/vendor/k8s.io/gengo/args/args.go:206 +0x1b7
main.main()
	/home/prow/go/src/sigs.k8s.io/descheduler/_tmp/kube-verify.1BwmFC/descheduler/vendor/k8s.io/code-generator/cmd/defaulter-gen/main.go:76 +0x365
make: *** [Makefile:130: verify-gen] Error 2

[pravarag]

@ingvagabund for the failing test, this error I've been getting since the very start. But, I'm still not able to debug that why this error coming only for this generator. I submitted separate PRs for other two generators and the changes worked without any such error. But, for this generator it's been failing with this error. Would you like to suggest any changes I could do here?

[ingvagabund]

diff --git a/hack/verify-defaulters.sh b/hack/verify-defaulters.sh
index 1e2c7e665..a1273332b 100755
--- a/hack/verify-defaulters.sh
+++ b/hack/verify-defaulters.sh
@@ -19,8 +19,8 @@ go build -o "${OS_OUTPUT_BINPATH}/defaulter-gen" "k8s.io/code-generator/cmd/defa
 
 ${OS_OUTPUT_BINPATH}/defaulter-gen \
             --go-header-file "hack/boilerplate/boilerplate.go.txt" \
-            --input-dirs "./pkg/apis/componentconfig/v1alpha1,./pkg/api/v1alpha1" \
-            --extra-peer-dirs "./pkg/apis/componentconfig/v1alpha1,./pkg/api/v1alpha1" \
+            --input-dirs "${PRJ_PREFIX}/pkg/apis/componentconfig/v1alpha1,${PRJ_PREFIX}/pkg/api/v1alpha1" \
+                       --extra-peer-dirs "${PRJ_PREFIX}/pkg/apis/componentconfig/v1alpha1,${PRJ_PREFIX}/pkg/api/v1alpha1" \
             --output-file-base zz_generated.defaults
 popd > /dev/null 2>&1

helped to get rid of the panic.

[pravarag]

helped to get rid of the panic.

@ingvagabund where did you add this part? Was it in verify-defaulters-gen script only?

[ingvagabund]

Yeah, just updated hack/verify-defaulters.sh

[pravarag]

Thanks @ingvagabund , the change has worked 😄

[ingvagabund]

Can you drop +? I'd expect the bash script to fail actually.

[pravarag]

Done

[ingvagabund]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, pravarag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ingvagabund]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment