-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pod anti-affinity check among nodes #1033
Merged
k8s-ci-robot
merged 9 commits into
kubernetes-sigs:master
from
10hin:check-podantiaffinity-among-nodes
Jun 5, 2023
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
877d858
pod anti-affinity check among nodes
10hin 111055a
Merge branch 'master' into check-podantiaffinity-among-nodes
10hin b55a886
avoid pod equality check with UID field
10hin 5c07e13
add test case for anti-affinity violation among different node
10hin f964b41
reduce ListPodsOnANode call
10hin 4d4baf9
Merge branch 'master' into check-podantiaffinity-among-nodes
10hin db00e96
fix old code
10hin d32c20f
apply gofumpt -w -extra
10hin d55ad53
Merge branch 'master' into check-podantiaffinity-among-nodes
10hin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could
nodeMap
replace the need to callListPodsOnANode()
in the loop below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or, maybe not nodeMap sorry... but looking at how we call
allPods
above and then callListPodsOnANode
, maybe we can cut out one of themThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review and sorry for my late reply.
I removed
ListPodsOnANode
call and keep code to query for all pods. Because listing pods by each node looks not efficient.But, I'm not sure that my code filtering pods for
podsOnANode
does same asListPodsOnANode
call.