pod anti-affinity check among nodes #1033

10hin · 2023-01-04T07:16:03Z

Current RemovePodsViolatingInterPodAntiAffinity policy implementation evicts pods violating Pod anti-affinity only on single Node. But in general context, violation of Pod anti-affinity is not limited to single Node.

This PullRequest(PR) changes to check violation of Pod anti-affinity not only on sigle node but among different nodes.

k8s-ci-robot · 2023-01-04T07:16:10Z

Welcome @10hin!

It looks like this is your first PR to kubernetes-sigs/descheduler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/descheduler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-01-04T07:16:11Z

Hi @10hin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

also add node equality check with Name for short-cut

damemi

/ok-to-test

damemi · 2023-01-31T19:47:07Z

pkg/framework/plugins/removepodsviolatinginterpodantiaffinity/pod_antiaffinity.go

+			Err: fmt.Errorf("error listing all pods: %v", err),
+		}
+	}
+	nodeMap := createNodeMap(nodes)


could nodeMap replace the need to call ListPodsOnANode() in the loop below?

or, maybe not nodeMap sorry... but looking at how we call allPods above and then call ListPodsOnANode, maybe we can cut out one of them

Thank you for your review and sorry for my late reply.

I removed ListPodsOnANode call and keep code to query for all pods. Because listing pods by each node looks not efficient.
But, I'm not sure that my code filtering pods for podsOnANode does same as ListPodsOnANode call.

10hin · 2023-02-10T04:35:34Z

pkg/framework/plugins/removepodsviolatinginterpodantiaffinity/pod_antiaffinity.go

+	runningPodFilter := func(pod *v1.Pod) bool {
+		return pod.Status.Phase != v1.PodSucceeded && pod.Status.Phase != v1.PodFailed
+	}


Also, I'm afraid that this code duplicating with following:

descheduler/pkg/descheduler/pod/pods.go

Lines 170 to 172 in 93a014e

f := func(pod *v1.Pod) bool {

return pod.Status.Phase != v1.PodSucceeded && pod.Status.Phase != v1.PodFailed

}

move klog/v2 import entry to bottom according to master code

knelasevero · 2023-06-02T12:58:10Z

/lgtm

damemi

/label tide/merge-method-squash

10hin · 2023-06-04T07:33:12Z

@damemi @knelasevero
Thank you for your reviews and actions.
I'm sorry if I am wrong, but, because CI status looks wait only for adding approved label (see attached image), is @damemi forgetting it? Or just wait for something?
If there are anything I can do in this PR, please tell me.

damemi

/approve

k8s-ci-robot · 2023-06-05T12:19:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [damemi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

10hin · 2023-06-05T12:39:01Z

@damemi @knelasevero Thank you for your support.

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://github.com/kubernetes-sigs/descheduler) | minor | `0.27.1` -> `0.28.0` | --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.28.0`](https://github.com/kubernetes-sigs/descheduler/releases/tag/v0.28.0): Descheduler v0.28.0 [Compare Source](kubernetes-sigs/descheduler@v0.27.1...v0.28.0) #### What's Changed - add unit tests for version compatibility check by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1096 - fix plugin arg conversion when using multiple profiles with same plugin by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1143 - Use dl.k8s.io instead of kubernetes-release bucket by [@ratnopamc](https://github.com/ratnopamc) in kubernetes-sigs/descheduler#1145 - update deprecated sets.String to generic sets by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1146 - helm: ability to override command and args. set args inline by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1151 - fix: imagepullsecrets indentation for kind: Deployment by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1150 - docs: supplement missing link by [@mikutas](https://github.com/mikutas) in kubernetes-sigs/descheduler#1159 - bump chart to v0.27.1 by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1160 - Custom labels for ServiceMonitor resource by [@nlamirault](https://github.com/nlamirault) in kubernetes-sigs/descheduler#1147 - pod anti-affinity check among nodes by [@10hin](https://github.com/10hin) in kubernetes-sigs/descheduler#1033 - PodLifeTime: support CrashLoopBackOff container state by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1164 - update pause image from 'kubernetes/pause' to 'registry.k8s.io/pause' by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1166 - TooManyRestart: state filter for CrashLoopBackOff by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1165 - Replace deprecated command with environment file by [@jongwooo](https://github.com/jongwooo) in kubernetes-sigs/descheduler#1173 - use pod informers for listing pods in removepodsviolatingtopologyspreadconstraint and removepodsviolatinginterpodantiaffinity by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1163 - removepodsviolatingtopologyspreadconstraint: implement explicit constraints by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1148 - FakeClientset: bump watch channel size by [@ingvagabund](https://github.com/ingvagabund) in kubernetes-sigs/descheduler#1174 - deschedule/balance order (continuation) by [@ingvagabund](https://github.com/ingvagabund) in kubernetes-sigs/descheduler#1177 - bump log level for processing info by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1141 - fix priority threshold by name alone by [@knelasevero](https://github.com/knelasevero) in kubernetes-sigs/descheduler#1186 - feat: Enable open telemetry tracing by [@harshanarayana](https://github.com/harshanarayana) in kubernetes-sigs/descheduler#1189 - bump to k8s 1.28 beta.0 by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1201 - nodefit: aggregate errors by [@lucming](https://github.com/lucming) in kubernetes-sigs/descheduler#1203 - fix: base configmap missing plugin RemoveDuplicates by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1207 - feat: Implement preferredDuringSchedulingIgnoredDuringExecution for RemovePodsViolatingNodeAffinity by [@jordipiqueselles](https://github.com/jordipiqueselles) in kubernetes-sigs/descheduler#1210 - fix: descheduler_loop_duration_seconds has wrong value by [@Abirdcfly](https://github.com/Abirdcfly) in kubernetes-sigs/descheduler#1215 - .gitattribute to not pollute PRs or stats by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1202 - Bump Kubernetes dependencies to v1.28.0 by [@JaneLiuL](https://github.com/JaneLiuL) in kubernetes-sigs/descheduler#1216 - profile: fix span attribute typo by [@antoinedeschenes](https://github.com/antoinedeschenes) in kubernetes-sigs/descheduler#1221 - k8s 1.28: update docs and go-version by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1224 #### New Contributors - [@ratnopamc](https://github.com/ratnopamc) made their first contribution in kubernetes-sigs/descheduler#1145 - [@mikutas](https://github.com/mikutas) made their first contribution in kubernetes-sigs/descheduler#1159 - [@nlamirault](https://github.com/nlamirault) made their first contribution in kubernetes-sigs/descheduler#1147 - [@10hin](https://github.com/10hin) made their first contribution in kubernetes-sigs/descheduler#1033 - [@jongwooo](https://github.com/jongwooo) made their first contribution in kubernetes-sigs/descheduler#1173 - [@jordipiqueselles](https://github.com/jordipiqueselles) made their first contribution in kubernetes-sigs/descheduler#1210 - [@Abirdcfly](https://github.com/Abirdcfly) made their first contribution in kubernetes-sigs/descheduler#1215 - [@antoinedeschenes](https://github.com/antoinedeschenes) made their first contribution in kubernetes-sigs/descheduler#1221 **Full Changelog**: kubernetes-sigs/descheduler@v0.27.0...v0.28.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.devmem.ru/projects/infra/pulls/949 Co-authored-by: Renovate Bot <renovate@devmem.ru> Co-committed-by: Renovate Bot <renovate@devmem.ru>

pod anti-affinity check among nodes

877d858

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 4, 2023

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 4, 2023

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 4, 2023

k8s-ci-robot requested review from knelasevero and seanmalloy January 4, 2023 07:16

10hin added 3 commits January 4, 2023 18:26

Merge branch 'master' into check-podantiaffinity-among-nodes

111055a

avoid pod equality check with UID field

b55a886

also add node equality check with Name for short-cut

add test case for anti-affinity violation among different node

5c07e13

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 6, 2023

damemi reviewed Jan 31, 2023

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2023

damemi reviewed Jan 31, 2023

View reviewed changes

reduce ListPodsOnANode call

f964b41

10hin commented Feb 10, 2023

View reviewed changes

10hin requested review from damemi and removed request for seanmalloy and knelasevero February 10, 2023 04:36

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 4, 2023

10hin added 2 commits May 31, 2023 19:23

Merge branch 'master' into check-podantiaffinity-among-nodes

4d4baf9

fix old code

db00e96

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2023

10hin added 2 commits May 31, 2023 19:54

apply gofumpt -w -extra

d32c20f

move klog/v2 import entry to bottom according to master code

Merge branch 'master' into check-podantiaffinity-among-nodes

d55ad53

k8s-ci-robot assigned knelasevero Jun 2, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2023

damemi reviewed Jun 2, 2023

View reviewed changes

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 2, 2023

damemi reviewed Jun 5, 2023

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2023

k8s-ci-robot merged commit 877d9b1 into kubernetes-sigs:master Jun 5, 2023

a7i mentioned this pull request Jun 6, 2023

use pod informers for listing pods in removepodsviolatingtopologyspreadconstraint and removepodsviolatinginterpodantiaffinity #1163

Merged

10hin deleted the check-podantiaffinity-among-nodes branch October 8, 2023 03:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pod anti-affinity check among nodes #1033

pod anti-affinity check among nodes #1033

10hin commented Jan 4, 2023

k8s-ci-robot commented Jan 4, 2023

k8s-ci-robot commented Jan 4, 2023

damemi left a comment

damemi Jan 31, 2023

damemi Jan 31, 2023

10hin Feb 10, 2023

10hin Feb 10, 2023

knelasevero commented Jun 2, 2023

damemi left a comment

10hin commented Jun 4, 2023

damemi left a comment

k8s-ci-robot commented Jun 5, 2023

10hin commented Jun 5, 2023

	f := func(pod *v1.Pod) bool {
	return pod.Status.Phase != v1.PodSucceeded && pod.Status.Phase != v1.PodFailed
	}

pod anti-affinity check among nodes #1033

pod anti-affinity check among nodes #1033

Conversation

10hin commented Jan 4, 2023

k8s-ci-robot commented Jan 4, 2023

k8s-ci-robot commented Jan 4, 2023

damemi left a comment

Choose a reason for hiding this comment

damemi Jan 31, 2023

Choose a reason for hiding this comment

damemi Jan 31, 2023

Choose a reason for hiding this comment

10hin Feb 10, 2023

Choose a reason for hiding this comment

10hin Feb 10, 2023

Choose a reason for hiding this comment

knelasevero commented Jun 2, 2023

damemi left a comment

Choose a reason for hiding this comment

10hin commented Jun 4, 2023

damemi left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jun 5, 2023

10hin commented Jun 5, 2023