Custom labels for ServiceMonitor resource #1147

nlamirault · 2023-05-12T16:50:58Z

No description provided.

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

k8s-ci-robot · 2023-05-12T16:51:06Z

Welcome @nlamirault!

It looks like this is your first PR to kubernetes-sigs/descheduler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/descheduler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-05-12T16:51:07Z

Hi @nlamirault. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

a7i · 2023-05-31T00:36:07Z

/ok-to-test

/lgtm

charts/descheduler/templates/servicemonitor.yaml

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

a7i · 2023-05-31T12:44:27Z

/label tide/merge-method-squash
/lgtm

damemi

/approve

k8s-ci-robot · 2023-05-31T13:39:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [damemi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://github.com/kubernetes-sigs/descheduler) | minor | `0.27.1` -> `0.28.0` | --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.28.0`](https://github.com/kubernetes-sigs/descheduler/releases/tag/v0.28.0): Descheduler v0.28.0 [Compare Source](kubernetes-sigs/descheduler@v0.27.1...v0.28.0) #### What's Changed - add unit tests for version compatibility check by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1096 - fix plugin arg conversion when using multiple profiles with same plugin by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1143 - Use dl.k8s.io instead of kubernetes-release bucket by [@ratnopamc](https://github.com/ratnopamc) in kubernetes-sigs/descheduler#1145 - update deprecated sets.String to generic sets by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1146 - helm: ability to override command and args. set args inline by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1151 - fix: imagepullsecrets indentation for kind: Deployment by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1150 - docs: supplement missing link by [@mikutas](https://github.com/mikutas) in kubernetes-sigs/descheduler#1159 - bump chart to v0.27.1 by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1160 - Custom labels for ServiceMonitor resource by [@nlamirault](https://github.com/nlamirault) in kubernetes-sigs/descheduler#1147 - pod anti-affinity check among nodes by [@10hin](https://github.com/10hin) in kubernetes-sigs/descheduler#1033 - PodLifeTime: support CrashLoopBackOff container state by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1164 - update pause image from 'kubernetes/pause' to 'registry.k8s.io/pause' by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1166 - TooManyRestart: state filter for CrashLoopBackOff by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1165 - Replace deprecated command with environment file by [@jongwooo](https://github.com/jongwooo) in kubernetes-sigs/descheduler#1173 - use pod informers for listing pods in removepodsviolatingtopologyspreadconstraint and removepodsviolatinginterpodantiaffinity by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1163 - removepodsviolatingtopologyspreadconstraint: implement explicit constraints by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1148 - FakeClientset: bump watch channel size by [@ingvagabund](https://github.com/ingvagabund) in kubernetes-sigs/descheduler#1174 - deschedule/balance order (continuation) by [@ingvagabund](https://github.com/ingvagabund) in kubernetes-sigs/descheduler#1177 - bump log level for processing info by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1141 - fix priority threshold by name alone by [@knelasevero](https://github.com/knelasevero) in kubernetes-sigs/descheduler#1186 - feat: Enable open telemetry tracing by [@harshanarayana](https://github.com/harshanarayana) in kubernetes-sigs/descheduler#1189 - bump to k8s 1.28 beta.0 by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1201 - nodefit: aggregate errors by [@lucming](https://github.com/lucming) in kubernetes-sigs/descheduler#1203 - fix: base configmap missing plugin RemoveDuplicates by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1207 - feat: Implement preferredDuringSchedulingIgnoredDuringExecution for RemovePodsViolatingNodeAffinity by [@jordipiqueselles](https://github.com/jordipiqueselles) in kubernetes-sigs/descheduler#1210 - fix: descheduler_loop_duration_seconds has wrong value by [@Abirdcfly](https://github.com/Abirdcfly) in kubernetes-sigs/descheduler#1215 - .gitattribute to not pollute PRs or stats by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1202 - Bump Kubernetes dependencies to v1.28.0 by [@JaneLiuL](https://github.com/JaneLiuL) in kubernetes-sigs/descheduler#1216 - profile: fix span attribute typo by [@antoinedeschenes](https://github.com/antoinedeschenes) in kubernetes-sigs/descheduler#1221 - k8s 1.28: update docs and go-version by [@a7i](https://github.com/a7i) in kubernetes-sigs/descheduler#1224 #### New Contributors - [@ratnopamc](https://github.com/ratnopamc) made their first contribution in kubernetes-sigs/descheduler#1145 - [@mikutas](https://github.com/mikutas) made their first contribution in kubernetes-sigs/descheduler#1159 - [@nlamirault](https://github.com/nlamirault) made their first contribution in kubernetes-sigs/descheduler#1147 - [@10hin](https://github.com/10hin) made their first contribution in kubernetes-sigs/descheduler#1033 - [@jongwooo](https://github.com/jongwooo) made their first contribution in kubernetes-sigs/descheduler#1173 - [@jordipiqueselles](https://github.com/jordipiqueselles) made their first contribution in kubernetes-sigs/descheduler#1210 - [@Abirdcfly](https://github.com/Abirdcfly) made their first contribution in kubernetes-sigs/descheduler#1215 - [@antoinedeschenes](https://github.com/antoinedeschenes) made their first contribution in kubernetes-sigs/descheduler#1221 **Full Changelog**: kubernetes-sigs/descheduler@v0.27.0...v0.28.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.devmem.ru/projects/infra/pulls/949 Co-authored-by: Renovate Bot <renovate@devmem.ru> Co-committed-by: Renovate Bot <renovate@devmem.ru>

Add: Custom labels for ServiceMonitor resource

9c1ee01

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 12, 2023

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 12, 2023

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 12, 2023

k8s-ci-robot requested review from damemi and seanmalloy May 12, 2023 16:51

nlamirault mentioned this pull request May 12, 2023

Descheduler component portefaix/portefaix-kubernetes#3894

Merged

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2023

k8s-ci-robot assigned a7i May 31, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2023

a7i reviewed May 31, 2023

View reviewed changes

charts/descheduler/templates/servicemonitor.yaml Outdated Show resolved Hide resolved

Fix: indentation

3a48633

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2023

k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 31, 2023

damemi reviewed May 31, 2023

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023

k8s-ci-robot merged commit b58ec3b into kubernetes-sigs:master May 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom labels for ServiceMonitor resource #1147

Custom labels for ServiceMonitor resource #1147

nlamirault commented May 12, 2023

k8s-ci-robot commented May 12, 2023

k8s-ci-robot commented May 12, 2023

a7i commented May 31, 2023

a7i commented May 31, 2023

damemi left a comment

k8s-ci-robot commented May 31, 2023

Custom labels for ServiceMonitor resource #1147

Custom labels for ServiceMonitor resource #1147

Conversation

nlamirault commented May 12, 2023

k8s-ci-robot commented May 12, 2023

k8s-ci-robot commented May 12, 2023

a7i commented May 31, 2023

a7i commented May 31, 2023

damemi left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented May 31, 2023