Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Travis CI Configuration #342

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Remove Travis CI Configuration #342

merged 1 commit into from
Jul 16, 2020

Conversation

seanmalloy
Copy link
Member

The e2e tests are now being run through Prow. Therefore the Travis CI
configuration can now be completely removed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 14, 2020
@seanmalloy
Copy link
Member Author

/assign @damemi @ingvagabund

@damemi please make the pull-descheduler-test-e2e-k8s-master CI check in the GitHub branch protection settings "Required". Thanks!

@damemi damemi mentioned this pull request Jul 14, 2020
Merged
@damemi
Copy link
Contributor

damemi commented Jul 14, 2020

@seanmalloy I opened a PR in kubernetes/test-infra#18303 to make this required
/hold
Until that merges

If you also want to work on it, we can update the test-e2e shell script to run a "version matrix" similar to what we had in travis. This approach was recommended by the sig-testing team on Slack, so it would be an acceptable solution to the fact that prow doesn't have this built in.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2020
@ingvagabund
Copy link
Contributor

I'd rather wait until the matrix is run in Prow as well before removing Travis config.

@damemi
Copy link
Contributor

damemi commented Jul 14, 2020

I'd rather wait until the matrix is run in Prow as well before removing Travis config.

sgtm, @seanmalloy do you want to update this PR to do that? Seems fitting to make the switch here

@ingvagabund
Copy link
Contributor

Once kubernetes/test-infra#18305 merges, we can go ahead with the PR.

@k8s-ci-robot
Copy link
Contributor

@seanmalloy: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-descheduler-test-e2e-k8s-release-1-18-1-18 bccc65d link /test pull-descheduler-test-e2e-k8s-release-1-18-1-18

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@seanmalloy
Remove Travis CI Configuration
2b66856 
The e2e tests are now being run through Prow. Therefore the Travis CI
configuration can now be completely removed.
@seanmalloy
Copy link
Member Author

/hold cancel

@damemi and @ingvagabund all the dependent pull requests have been merged. This is ready for review again.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2020
@ingvagabund
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2020
damemi
damemi approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Farewell travis
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 550f683 into kubernetes-sigs:master Jul 16, 2020
@seanmalloy seanmalloy mentioned this pull request Jul 17, 2020
Closed
@seanmalloy seanmalloy deleted the remove-travis-ci-config branch July 23, 2020 03:39
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Merge pull request kubernetes-sigs#342 from KohlsTechnology/remove-tr…
1a2a87b 
…avis-ci-config

Remove Travis CI Configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi approved these changes

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees

@damemi damemi

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanmalloy @damemi @ingvagabund @k8s-ci-robot