Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make descheduler e2e required #18303

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Jul 14, 2020

This test was added in #18292 as optional while we tested it. It seems to work now, so we can make it required. This will enable the changes in kubernetes-sigs/descheduler#342 (comment)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 14, 2020
@damemi
Copy link
Contributor Author

damemi commented Jul 14, 2020

/cc @seanmalloy @ingvagabund

@k8s-ci-robot
Copy link
Contributor

@damemi: GitHub didn't allow me to request PR reviews from the following users: seanmalloy.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @seanmalloy @ingvagabund

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 14, 2020
@ingvagabund
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit b99a6fd into kubernetes:master Jul 14, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 14, 2020
@k8s-ci-robot
Copy link
Contributor

@damemi: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key descheduler-presubmits-master.yaml using file config/jobs/kubernetes-sigs/descheduler/descheduler-presubmits-master.yaml

In response to this:

This test was added in #18292 as optional while we tested it. It seems to work now, so we can make it required. This will enable the changes in kubernetes-sigs/descheduler#342 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants