-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify resourceUsage.Value() to resourceUsage.MilliValue() #493
Modify resourceUsage.Value() to resourceUsage.MilliValue() #493
Conversation
Welcome @fancc! |
Hi @fancc. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resourceUsagePercentages
is only used in logging, we should fix this though it won't affect the result.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/cc @ingvagabund
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, fancc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -248,7 +248,7 @@ func resourceUsagePercentages(nodeUsage NodeUsage) map[v1.ResourceName]float64 { | |||
for resourceName, resourceUsage := range nodeUsage.usage { | |||
cap := nodeCapacity[resourceName] | |||
if !cap.IsZero() { | |||
resourceUsagePercentage[resourceName] = 100 * float64(resourceUsage.Value()) / float64(cap.Value()) | |||
resourceUsagePercentage[resourceName] = 100 * float64(resourceUsage.MilliValue()) / float64(cap.MilliValue()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right :)
// Value returns the unscaled value of q rounded up to the nearest integer away from 0.
func (q *Quantity) Value() int64
/lgtm |
…entage Modify resourceUsage.Value() to resourceUsage.MilliValue()
I have a node with a CPU that can be allocated 3000m. I actually used 2015m. I set the threshold value to 70%. So my node has not reached this threshold, but I check the log and show that the CPU usage is 100% because When calculating usagePercentage, the Value() method is used, so here is the calculation of 3/3 as 100%, I think this may be misleading.