Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LowNodeUtilization: unit test resourceUsagePercentages to validate percentages are computed correctly #497

Merged
merged 1 commit into from
Feb 12, 2021
Merged

LowNodeUtilization: unit test resourceUsagePercentages to validate percentages are computed correctly #497

merged 1 commit into from
Feb 12, 2021

Conversation

ingvagabund
Copy link
Contributor

To complement #493.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 11, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 11, 2021
@ingvagabund
Copy link
Contributor Author

@damemi @lixiang233 PTAL

damemi
damemi reviewed Feb 11, 2021
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2021
@seanmalloy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2021
@seanmalloy
Copy link
Member

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit e566172 into kubernetes-sigs:master Feb 12, 2021
@ingvagabund ingvagabund deleted the resourceUsagePercentages-unit-test branch February 12, 2021 08:02
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Merge pull request kubernetes-sigs#497 from ingvagabund/resourceUsage…
60d8ecc 
…Percentages-unit-test

LowNodeUtilization: unit test resourceUsagePercentages to validate percentages are computed correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi left review comments

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@seanmalloy seanmalloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ingvagabund @k8s-ci-robot @seanmalloy @damemi