-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to k8s 1.25 #933
Bump to k8s 1.25 #933
Conversation
/cc @damemi |
296f613
to
518abe3
Compare
@a7i thanks for picking this up |
Still waiting on this kubernetes/test-infra#27348 |
/retest-required |
822e53e
to
02673c4
Compare
😅 finally! let's get this reviewed/merged before something else breaks. I kept the commits separate to make the review easier but can squash if you suggest. |
…formers for descheduler unit tests update go to 1.19 and helm kubernetes cluster to 1.25 bump -rc.0 to 1.25 GA bump k8s utils library bump golang-ci use go 1.19 for helm github action upgrade kubectl from 0.20 to 0.25 Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks @a7i
k8s.io/component-base v0.25.0 | ||
k8s.io/component-helpers v0.25.0 | ||
k8s.io/klog/v2 v2.70.1 | ||
k8s.io/kubectl v0.25.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we merge #938 first, or after this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like #938 depends on this (specifically the go1.19 bump), so we can merge this first
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
based on top of #918