Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to k8s 1.25 #933

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Bump to k8s 1.25 #933

merged 2 commits into from
Sep 6, 2022

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Sep 2, 2022

based on top of #918

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 2, 2022
@a7i
Copy link
Contributor Author

a7i commented Sep 2, 2022

/cc @damemi

@a7i a7i force-pushed the 1.25-rc.0 branch 2 times, most recently from 296f613 to 518abe3 Compare September 2, 2022 02:49
@damemi
Copy link
Contributor

damemi commented Sep 2, 2022

@a7i thanks for picking this up
Now that v0.25.0 is out, we can skip the rc.0 bump and go right to the GA (no point in soaking the rc when GA is already available)

@a7i a7i changed the title Bump to k8s 1.25-rc.0 Bump to k8s 1.25 Sep 2, 2022
@a7i
Copy link
Contributor Author

a7i commented Sep 3, 2022

Still waiting on this kubernetes/test-infra#27348

@ingvagabund
Copy link
Contributor

/retest-required

@a7i a7i force-pushed the 1.25-rc.0 branch 2 times, most recently from 822e53e to 02673c4 Compare September 4, 2022 14:05
@a7i
Copy link
Contributor Author

a7i commented Sep 4, 2022

😅 finally! let's get this reviewed/merged before something else breaks. I kept the commits separate to make the review easier but can squash if you suggest.

/cc @JaneLiuL @damemi @ingvagabund

…formers for descheduler unit tests

update go to 1.19 and helm kubernetes cluster to 1.25
bump -rc.0 to 1.25 GA
bump k8s utils library
bump golang-ci
use go 1.19 for helm github action
upgrade kubectl from 0.20 to 0.25

Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
@a7i
Copy link
Contributor Author

a7i commented Sep 4, 2022

/retest

Copy link
Member

@JaneLiuL JaneLiuL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks @a7i

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2022
@damemi damemi mentioned this pull request Sep 6, 2022
k8s.io/component-base v0.25.0
k8s.io/component-helpers v0.25.0
k8s.io/klog/v2 v2.70.1
k8s.io/kubectl v0.25.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we merge #938 first, or after this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like #938 depends on this (specifically the go1.19 bump), so we can merge this first

@damemi damemi mentioned this pull request Sep 6, 2022
@damemi
Copy link
Contributor

damemi commented Sep 6, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit ea8e648 into kubernetes-sigs:master Sep 6, 2022
@a7i a7i deleted the 1.25-rc.0 branch September 6, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants