Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dependency on kubectl #938

Merged
merged 1 commit into from
Sep 6, 2022
Merged

remove dependency on kubectl #938

merged 1 commit into from
Sep 6, 2022

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Sep 4, 2022

one less dependency we have to worry about

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 4, 2022
@a7i a7i marked this pull request as ready for review September 4, 2022 14:50
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2022
@a7i a7i mentioned this pull request Sep 6, 2022
Closed
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2022
damemi
damemi reviewed Sep 6, 2022
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
thanks @a7i, looks like there's just an unused variable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2022
damemi
damemi reviewed Sep 6, 2022
View reviewed changes
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
@damemi damemi mentioned this pull request Sep 6, 2022
Merged
@damemi
Copy link
Contributor

damemi commented Sep 6, 2022

Looks like we need a 1.19 bump similar to #801
working on a pr

@a7i
Copy link
Contributor Author

a7i commented Sep 6, 2022

Looks like we need a 1.19 bump similar to #801 working on a pr

This is actually done in the 0.25 PR but I guess it makes sense to keep the two separate?

@damemi
Copy link
Contributor

damemi commented Sep 6, 2022

Ah okay, I missed that it was done there. It can be easier to keep them separate (or at least in separate commits) but this is fine

@a7i
remove dependency on kubectl
1265b4c 
Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
@a7i a7i requested review from damemi and removed request for ingvagabund, lixiang233 and JaneLiuL September 6, 2022 16:26
@damemi
Copy link
Contributor

damemi commented Sep 6, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5a2a180 into kubernetes-sigs:master Sep 6, 2022
@a7i a7i deleted the remove-kubectl-dep branch September 6, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi Awaiting requested review from damemi

Assignees

@damemi damemi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a7i @k8s-ci-robot @damemi