Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote HTTPRoute backend protocol from experimental to extended #3108

Merged

Conversation

dprotaso
Copy link
Contributor

What type of PR is this?
/kind gep
/area conformance

What this PR does / why we need it:
This promotes backend protocol selection as part of Gateway v1.2 release

Which issue(s) this PR fixes:
Part of #1911

Does this PR introduce a user-facing change?:

Backend Protocol Selection is no longer experimental and is now part of HTTPRoute Extended Conformance

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/gep PRs related to Gateway Enhancement Proposal(GEP) area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 22, 2024
@youngnick
Copy link
Contributor

Is there any website documentation we need to update for this as well?

Aside from that, lgtm, I'll approve.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2024
@dprotaso
Copy link
Contributor Author

dprotaso commented May 24, 2024

Sorry yeah - I need to drop this notice on this page https://gateway-api.sigs.k8s.io/guides/backend-protocol/

Screenshot 2024-05-24 at 10 35 06 AM

@dprotaso
Copy link
Contributor Author

done

@robscott
Copy link
Member

Thanks @dprotaso! This LGTM, but I think we need to have some kind of solution for #3115 before we accept docs updates for unreleased changes. I don't really have a great solution yet, but open to ideas.

@dprotaso
Copy link
Contributor Author

Oh I didn't realize you don't have branches for the docs - should I rollback the docs change?

@robscott
Copy link
Member

Oh I didn't realize you don't have branches for the docs - should I rollback the docs change?

Yeah unfortunately that's probably the best for now, but I really don't want to miss changing docs in the future. Hoping someone can help us figure out a better approach to docs versioning to make this less painful in the future.

@dprotaso
Copy link
Contributor Author

Pulled the docs changes into a separate PR - #3120

@dprotaso
Copy link
Contributor Author

I pulled out the docs changes into a separate PR. This change is ready to be merged.

@dprotaso
Copy link
Contributor Author

weird verify took 2h

/retest

@robscott
Copy link
Member

robscott commented Jun 3, 2024

Thanks @dprotaso!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, robscott, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d400a8b into kubernetes-sigs:main Jun 3, 2024
8 checks passed
BobyMCbobs pushed a commit to BobyMCbobs/kubernetes-sigs-gateway-api that referenced this pull request Jul 10, 2024
BobyMCbobs pushed a commit to BobyMCbobs/kubernetes-sigs-gateway-api that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants