Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote HTTPRoute backend protocol from experimental to extended #3108

Merged
merged 1 commit into from
Jun 3, 2024
Merged

promote HTTPRoute backend protocol from experimental to extended #3108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions pkg/features/features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,12 @@ const (

// This option indicates support for HTTPRoute parentRef port (extended conformance).
SupportHTTPRouteParentRefPort SupportedFeature = "HTTPRouteParentRefPort"

// This option indicates support for HTTPRoute with a backendref with an appProtocol 'kubernetes.io/h2c' (extended conformance)
SupportHTTPRouteBackendProtocolH2C SupportedFeature = "HTTPRouteBackendProtocolH2C"

// This option indicates support for HTTPRoute with a backendref with an appProtoocol 'kubernetes.io/ws' (extended conformance)
SupportHTTPRouteBackendProtocolWebSocket SupportedFeature = "HTTPRouteBackendProtocolWebSocket"
)

// HTTPRouteExtendedFeatures includes all extended features for HTTPRoute
Expand All @@ -164,6 +170,8 @@ var HTTPRouteExtendedFeatures = sets.New(
SupportHTTPRouteBackendTimeout,
SupportHTTPRouteParentRefPort,
SupportHTTPRouteBackendRequestHeaderModification,
SupportHTTPRouteBackendProtocolH2C,
SupportHTTPRouteBackendProtocolWebSocket,
)

// -----------------------------------------------------------------------------
Expand All @@ -173,21 +181,13 @@ var HTTPRouteExtendedFeatures = sets.New(
const (
// This option indicates support for Destination Port matching.
SupportHTTPRouteDestinationPortMatching SupportedFeature = "HTTPRouteDestinationPortMatching"

// This option indicates support for HTTPRoute with a backendref with an appProtocol 'kubernetes.io/h2c'
SupportHTTPRouteBackendProtocolH2C SupportedFeature = "HTTPRouteBackendProtocolH2C"

// This option indicates support for HTTPRoute with a backendref with an appProtoocol 'kubernetes.io/ws'
SupportHTTPRouteBackendProtocolWebSocket SupportedFeature = "HTTPRouteBackendProtocolWebSocket"
)

// HTTPRouteExperimentalFeatures includes all the supported experimental features, currently only
// available in our experimental release channel.
// Implementations have the flexibility to opt-in for either specific features or the entire set.
var HTTPRouteExperimentalFeatures = sets.New(
SupportHTTPRouteDestinationPortMatching,
SupportHTTPRouteBackendProtocolH2C,
SupportHTTPRouteBackendProtocolWebSocket,
)

// -----------------------------------------------------------------------------
Expand Down