Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing kind v1.30 image ref #3329

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fixing kind v1.30 image ref #3329

merged 1 commit into from
Sep 10, 2024

Conversation

robscott
Copy link
Member

What type of PR is this?
/kind bug
/kind failing-test

What this PR does / why we need it:
Looks like we accidentally missed a few characters when setting up the multi-version kind tests.

Does this PR introduce a user-facing change?:

NONE

/cc @shaneutt

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 10, 2024
shaneutt
shaneutt approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2024
mlavacca
mlavacca approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it, @robscott

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, robscott, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mlavacca,robscott,shaneutt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ffe4b63 into kubernetes-sigs:main Sep 10, 2024
13 checks passed
@shaneutt shaneutt deleted the kind-sha-fix branch September 10, 2024 21:16
mlavacca pushed a commit to mlavacca/gateway-api that referenced this pull request Oct 28, 2024
@robscott @mlavacca
Fixing kind v1.30 image ref (kubernetes-sigs#3329)
5be3682
@mlavacca mlavacca mentioned this pull request Oct 28, 2024
Merged
k8s-ci-robot pushed a commit that referenced this pull request Oct 28, 2024
@mlavacca @robscott
[release-1.1] Backport CI improvements (#3417)
c835e83 
* Fix CEL tests for v1.28+ (#3325)

* feat: validate CRDs on specific k8s versions (#3316)

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>

* finalize verify->crds-validation migration (#3330)

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>

* Fixing kind v1.30 image ref (#3329)

---------

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Co-authored-by: Rob Scott <robertjscott@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlavacca mlavacca mlavacca approved these changes

@shaneutt shaneutt shaneutt approved these changes

Assignees

@shaneutt shaneutt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robscott @k8s-ci-robot @shaneutt @mlavacca