Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cel validation on multiple K8S versions #3316

Merged
merged 1 commit into from
Sep 9, 2024
Merged

feat: cel validation on multiple K8S versions #3316

merged 1 commit into from
Sep 9, 2024

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Sep 5, 2024

What type of PR is this?

/kind test

What this PR does / why we need it:

CEL validation tests are run against multiple clusters having different K8S versions

Which issue(s) this PR fixes:

Fixes #3206

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 5, 2024
@mlavacca
Copy link
Member Author

mlavacca commented Sep 5, 2024

/test all

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2024
@mlavacca mlavacca force-pushed the issue-3206 branch 2 times, most recently from 45a3e46 to f7d4381 Compare September 9, 2024 14:38
@mlavacca
Copy link
Member Author

mlavacca commented Sep 9, 2024

/test all

@mlavacca mlavacca force-pushed the issue-3206 branch 3 times, most recently from ab1f6cb to 4bac9ef Compare September 9, 2024 15:02
@mlavacca
feat: validate CRDs on specific k8s versions
744260e 
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca
Copy link
Member Author

mlavacca commented Sep 9, 2024

/test all

@mlavacca mlavacca marked this pull request as ready for review September 9, 2024 16:23
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2024
@robscott
Copy link
Member

robscott commented Sep 9, 2024

Thanks @mlavacca!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 92b1154 into kubernetes-sigs:main Sep 9, 2024
8 checks passed
@robscott robscott mentioned this pull request Sep 9, 2024
Merged
@mlavacca mlavacca mentioned this pull request Sep 10, 2024
Merged
@mlavacca
Copy link
Member Author

/cherrypick release-1.1

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mlavacca: new pull request created: #3416

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Oct 28, 2024
Closed
mlavacca added a commit to mlavacca/gateway-api that referenced this pull request Oct 28, 2024
@mlavacca
feat: validate CRDs on specific k8s versions (kubernetes-sigs#3316)
34a0ebb 
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca mlavacca mentioned this pull request Oct 28, 2024
Merged
k8s-ci-robot pushed a commit that referenced this pull request Oct 28, 2024
@mlavacca @robscott
[release-1.1] Backport CI improvements (#3417)
c835e83 
* Fix CEL tests for v1.28+ (#3325)

* feat: validate CRDs on specific k8s versions (#3316)

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>

* finalize verify->crds-validation migration (#3330)

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>

* Fixing kind v1.30 image ref (#3329)

---------

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Co-authored-by: Rob Scott <robertjscott@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott Awaiting requested review from robscott

@youngnick youngnick Awaiting requested review from youngnick

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CEL: Need Test Coverage against Multiple Kubernetes Versions
4 participants
@mlavacca @k8s-ci-robot @robscott @k8s-infra-cherrypick-robot