Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway-api crds-validation presubmit jobs #33448

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Sep 10, 2024

Description

Creation of a new presubmit job to run independently from verify the test.crds-validation target on a specific k8s version (latest-4, 1.27 at the moment of writing). Related Gateway API PR: kubernetes-sigs/gateway-api#3316

Since @robscott fixed the errors in kubernetes-sigs/gateway-api#3325 for k8s >= 1.28, then additional jobs, for versions 1.28, 1.29, 1.30, and 1.31 are added

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/jobs labels Sep 10, 2024
@k8s-ci-robot k8s-ci-robot requested a review from bowei September 10, 2024 08:34
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Sep 10, 2024
@mlavacca
Copy link
Member Author

/cc @robscott @shaneutt @youngnick

@mlavacca mlavacca changed the title feat: gateway-api crds-validation presubmit job gateway-api crds-validation presubmit job Sep 10, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 10, 2024
@mlavacca mlavacca changed the title gateway-api crds-validation presubmit job gateway-api crds-validation presubmit jobs Sep 10, 2024
@robscott
Copy link
Member

Thanks @mlavacca!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca mlavacca force-pushed the add-crds-validation-1-job branch from 7d66450 to 5c657fd Compare September 10, 2024 19:27
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2024
@robscott
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3b3ca74 into kubernetes:master Sep 10, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@mlavacca: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gateway-api-config.yaml using file config/jobs/kubernetes-sigs/gateway-api/gateway-api-config.yaml

In response to this:

Description

Creation of a new presubmit job to run independently from verify the test.crds-validation target on a specific k8s version (latest-4, 1.27 at the moment of writing). Related Gateway API PR: kubernetes-sigs/gateway-api#3316

Since @robscott fixed the errors in kubernetes-sigs/gateway-api#3325 for k8s >= 1.28, then additional jobs, for versions 1.28, 1.29, 1.30, and 1.31 are added

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants