emit metrics even for success scenarios

[Sneha-at]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
The PR emits the metric csidriver_operation_errors with disk type for success scenarios
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
This is related to PR #1227
Does this PR introduce a user-facing change?:

Add disk type for all operations metrics.

[k8s-ci-robot]

Hi @Sneha-at. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mattcary]

/ok-to-test
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, Sneha-at

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mattcary]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mattcary]

Nit: can you change the release note to say "Add disk type for all operations metrics."? That will read better in the changelog (remember we just directly copy the release notes into the changelog. Read through the changelogs to get a sense of how they sound & what wording is most useful).

[sunnylovestiramisu]

This one also needs to be cherry-picked back to release 1.10, 1.9 and 1.8

[sunnylovestiramisu]

/cherry-pick release-1.10

[k8s-infra-cherrypick-robot]

@sunnylovestiramisu: new pull request created: #1295

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sunnylovestiramisu]

/cherry-pick release-1.9

[k8s-infra-cherrypick-robot]

@sunnylovestiramisu: new pull request created: #1296

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sunnylovestiramisu]

/cherry-pick release-1.8

[k8s-infra-cherrypick-robot]

@sunnylovestiramisu: new pull request created: #1297

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.