Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.9] emit metrics even for success scenarios #1296

Merged
merged 1 commit into from
Jul 18, 2023
Merged

[release-1.9] emit metrics even for success scenarios #1296

merged 1 commit into from
Jul 18, 2023

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #1287

/assign sunnylovestiramisu

Add disk type for all operations metrics.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 18, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 18, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 18, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 18, 2023
@mattcary
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2023
@sunnylovestiramisu
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 96741d1 into kubernetes-sigs:release-1.9 Jul 18, 2023
@sunnylovestiramisu sunnylovestiramisu mentioned this pull request Jul 21, 2023
Merged
k8s-ci-robot added a commit that referenced this pull request Jul 21, 2023
@k8s-ci-robot
Merge pull request #1305 from sunnylovestiramisu/automated-cherry-pic…
3d1fd21 
…k-of-#1101-#1227-#1296-upstream-release-1.7

Automated cherry pick of #1101: Add provisionedThroughput for hyperdisk
#1227: Adding new metric pdcsi_operation_errors to fetch error
#1296: emit metrics even for success scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiyiz leiyiz Awaiting requested review from leiyiz

@msau42 msau42 Awaiting requested review from msau42

Assignees

@mattcary mattcary

@sunnylovestiramisu sunnylovestiramisu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@k8s-infra-cherrypick-robot @mattcary @k8s-ci-robot @sunnylovestiramisu @Sneha-at