-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update jobset status without spec #282
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: homily707 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @homily707. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test can you explain why this fixes the issue you linked? |
I have the same problem in #141 in my own project, and I searched this solution in minio-operator. I have build image and it run normally, but it failed the test, I'm confused about the job failed details. I'll check it out later. |
/retest |
Interesting, thanks for working on this fix. Let's make sure there are no unintended side effects before merging this. I see the tests pass, I think it would be good to also manually deploy some of the example workloads in the examples/ directory and verify A) that they work, and B) the "Unknown field" log message doesn't appear. |
A) It works fine The operator don't have this warning message, it only appears in integration test. |
to fix #141