Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update jobset status without spec #282

Closed
wants to merge 1 commit into from

Conversation

homily707
Copy link

to fix #141

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 30, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: homily707 / name: homily (90ed74c)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: homily707
Once this PR has been reviewed and has the lgtm label, please assign danielvegamyhre for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 30, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @homily707. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 30, 2023
@kannon92
Copy link
Contributor

/ok-to-test

can you explain why this fixes the issue you linked?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 30, 2023
@homily707
Copy link
Author

/ok-to-test

can you explain why this fixes the issue you linked?

I have the same problem in #141 in my own project, and I searched this solution in minio-operator.
The reason of the problem is that when you updateStatus, the "CreationTime" is marshaled as "null" instead of not rendering at all.
If you don't set spec at all, the problem solved, it's a very elegant solution, it works in my own project , I think it will also work here. So I open this PR.

I have build image and it run normally, but it failed the test, I'm confused about the job failed details. I'll check it out later.

@homily707
Copy link
Author

/retest

@danielvegamyhre
Copy link
Contributor

Interesting, thanks for working on this fix. Let's make sure there are no unintended side effects before merging this. I see the tests pass, I think it would be good to also manually deploy some of the example workloads in the examples/ directory and verify A) that they work, and B) the "Unknown field" log message doesn't appear.

@homily707
Copy link
Author

Interesting, thanks for working on this fix. Let's make sure there are no unintended side effects before merging this. I see the tests pass, I think it would be good to also manually deploy some of the example workloads in the examples/ directory and verify A) that they work, and B) the "Unknown field" log message doesn't appear.

A) It works fine
B) "Unknown field" warning log numbers reduce, but still exists

The operator don't have this warning message, it only appears in integration test.
need deeper exploration for the reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown fields in logs
4 participants