not send the spec in UpdateStatus #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
previously approved these changes
Mar 15, 2023
|
What an elegant solution 🧐 |
|
|
pjuarezd
force-pushed
the
no-error-messages
branch
from
b69096e to
132be72
Compare
dvaldivia
approved these changes
Mar 15, 2023
pjuarezd
changed the title
reivaj05
reviewed
Mar 15, 2023
| @@ -39,6 +39,7 @@ func (c *Controller) updateTenantStatusWithRetry(ctx context.Context, tenant *mi | |||
| // You can use DeepCopy() to make a deep copy of original object and modify this copy | |||
| // Or create a copy manually for better performance | |||
| tenantCopy := tenant.DeepCopy() | |||
| tenantCopy.Spec = miniov2.TenantSpec{} | |||
There was a problem hiding this comment.
would nil work or do we need an instance of TenantSpec later in the code?
There was a problem hiding this comment.
I think nil will not work, cannot assign nil to a field of type TenantSpec (Tenant.Spec).
but yeah, we don't need Spec later in the code, that is why we are reseting it's value, c.minioClientSet.MinioV2().Tenants(tenant.Namespace).UpdateStatus(ctx, tenantCopy, opts) only needs the values in the Tenant.Status struct and ignores all of the other values in the Tenant.Spec struct.
reivaj05
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cheers to @dvaldivia
Partially fixes #1388, the error logs on Console are shown because we (somehow) included the creationTimestamp field under volumeClaimTemplates fields, no more!