-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: entrypoint is broken on cgroup v2 #2013
Comments
perhaps we should check for v1/v2 and split the code-path here? |
I'm also actually not sure if Kubernetes even has any cgroupsv2 CI at all yet, last I checked someone decided that meant we had to use fedora VMs ... which we didn't have a GCE VM image handy for. AFAIK SIG Node never sorted that out. EDIT: which is not to say kind shouldn't be fixed, but rather that we probably also need to look at getting upstream CI as well still. |
v2 support for `fix_cgroup()` was broken: kubernetes-sigs#2013 As CgroupNS is enabled by default on v2 hosts, we do not need to mess around the cgroup mounts. However, at least we need to create "/kubelet" cgroup (kubernetes-sigs#1969). Fix kubernetes-sigs#2013 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
PR: #2014 |
v2 support for `fix_cgroup()` was broken: kubernetes-sigs#2013 As CgroupNS is enabled by default on v2 hosts, we do not need to mess around the cgroup mounts. However, at least we need to create "/kubelet" cgroup (kubernetes-sigs#1969). Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
v2 support for `fix_cgroup()` was broken: kubernetes-sigs#2013 As CgroupNS is enabled by default on v2 hosts, we do not need to mess around the cgroup mounts. However, at least we need to create "/kubelet" cgroup (kubernetes-sigs#1969). Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
v2 support for `fix_cgroup()` was broken: kubernetes-sigs#2013 As CgroupNS is enabled by default on v2 hosts, we do not need to mess around the cgroup mounts. However, at least we need to create "/kubelet" cgroup (kubernetes-sigs#1969). Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
What happened:
fix_cgroup()
change in https://github.com/kubernetes-sigs/kind/pull/1995/files broke cgroup v2What you expected to happen:
It should work
How to reproduce it (as minimally and precisely as possible):
Minimal repro:
Environment:
kind version
): 26637e2 (Jan 19, 2021)The text was updated successfully, but these errors were encountered: