Fix entrypoint cgroups mounts #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
aojea
force-pushed
the
add-github-actions-docker
branch
3 times, most recently
from
d542ebf to
57afd22
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
aojea
force-pushed
the
add-github-actions-docker
branch
2 times, most recently
from
1bdc594 to
67b4b47
Compare
This was referenced Dec 30, 2020
Closed
|
Excellent! I'll take a closer look soon, popping my head up today but I'm back on the 5th. |
BenTheElder
force-pushed
the
add-github-actions-docker
branch
from
67b4b47 to
28e8771
Compare
|
rebased, updated base image bump, etc. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Merged
|
This change seems to broke cgroup v2 ( #2013) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cgroups mount points are different depending on the provider or the platform where kind is running.
We need to be able to handle this different mountpoints, or kubelet will fail to start.
Fixes: #1969