-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix paths. #298
doc: fix paths. #298
Conversation
Hi @tao12345666333. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks @tao12345666333
8b5d1fd
to
ce11e33
Compare
/ok-to-test |
ce11e33
to
0978be1
Compare
Addressed. |
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
0978be1
to
c622a73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tao12345666333 if you join the kubernetes-sigs org (file an issue to https://github.com/kubernetes/org) then you won't need |
OK, Thanks. @BenTheElder ❤️ |
* Improve execute command retries * Fix kubeconfig condition * Fix ecr login when ecr is in another region * Remove comment * [BUILD] 0.17.0-0.3.0: New pre-release * Prepare for next version: 0.17.0-0.3.0-SNAPSHOT * Prepare for next version: 0.17.0-0.3.1-SNAPSHOT * Improve retry logic --------- Co-authored-by: stratiocommit <stratiocommit@stratio.com>
* chore: bump azure provider * bump azure provider version * [CLOUD-109] Integrar GKE como nuevo provider (kubernetes-sigs#320) * Initial gke support * Fix gcr authentication * Minor fixes * Fix gcr authentication * Enable machine pools for gke * Enable gke in capg * Add google artifact registry support * Add gke version validation * Improve error message * Update cluster-operator version * Fix gke install logic * Improve execute command retries (kubernetes-sigs#298) * Improve execute command retries * Fix kubeconfig condition * Fix ecr login when ecr is in another region * Remove comment * [BUILD] 0.17.0-0.3.0: New pre-release * Prepare for next version: 0.17.0-0.3.0-SNAPSHOT * Prepare for next version: 0.17.0-0.3.1-SNAPSHOT * Improve retry logic --------- Co-authored-by: stratiocommit <stratiocommit@stratio.com> * Feature/add infra validations (kubernetes-sigs#335) * version v0.18.0-alpha * update docs for v0.17.0 * fix kind version in readme * comments-update-buildcontext * Added validations for azs, k8sVersion, vpcs and subnets in each provider * fixing dependency bugs * Merge with master * fixed gcp * Update pkg/cluster/internal/validate/gcp.go Co-authored-by: esierra-stratio <102975650+esierra-stratio@users.noreply.github.com> * fixed build * Update CHANGELOG.md --------- Co-authored-by: Benjamin Elder <bentheelder@google.com> Co-authored-by: Daman <aroradaman@gmail.com> Co-authored-by: Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com> Co-authored-by: esierra-stratio <102975650+esierra-stratio@users.noreply.github.com> * version v0.18.0-alpha * delete unneeded files * add CHANGELOG --------- Co-authored-by: Francisco Augusto <faugusto@stratio.com> Co-authored-by: stratiocommit <stratiocommit@stratio.com> Co-authored-by: lreciomelero <120394823+lreciomelero@users.noreply.github.com> Co-authored-by: Benjamin Elder <bentheelder@google.com> Co-authored-by: Daman <aroradaman@gmail.com> Co-authored-by: Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com>
Probably all the paths have been fixed. 😆
Signed-off-by: Jintao Zhang zhangjintao9020@gmail.com