Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix paths. #298

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Conversation

tao12345666333
Copy link
Member

Probably all the paths have been fixed. 😆

Signed-off-by: Jintao Zhang zhangjintao9020@gmail.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 14, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @tao12345666333. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 14, 2019
images/node/README.md Outdated Show resolved Hide resolved
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks @tao12345666333

@tao12345666333 tao12345666333 force-pushed the fix-path branch 2 times, most recently from 8b5d1fd to ce11e33 Compare February 14, 2019 02:41
@tao12345666333
Copy link
Member Author

images/base/README.md Outdated Show resolved Hide resolved
@BenTheElder
Copy link
Member

/ok-to-test
thanks for this :-)

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2019
@tao12345666333
Copy link
Member Author

tao12345666333 commented Feb 14, 2019

Addressed.

README.md Outdated Show resolved Hide resolved
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2019
@BenTheElder
Copy link
Member

@tao12345666333 if you join the kubernetes-sigs org (file an issue to https://github.com/kubernetes/org) then you won't need /ok-to-test anymore 😅

@k8s-ci-robot k8s-ci-robot merged commit 44cc4e7 into kubernetes-sigs:master Feb 14, 2019
@tao12345666333 tao12345666333 deleted the fix-path branch February 14, 2019 04:54
@tao12345666333
Copy link
Member Author

OK, Thanks. @BenTheElder ❤️

stg-0 pushed a commit to stg-0/kind that referenced this pull request Feb 6, 2024
* Improve execute command retries

* Fix kubeconfig condition

* Fix ecr login when ecr is in another region

* Remove comment

* [BUILD] 0.17.0-0.3.0: New pre-release

* Prepare for next version: 0.17.0-0.3.0-SNAPSHOT

* Prepare for next version: 0.17.0-0.3.1-SNAPSHOT

* Improve retry logic

---------

Co-authored-by: stratiocommit <stratiocommit@stratio.com>
stg-0 pushed a commit to stg-0/kind that referenced this pull request Feb 6, 2024
* chore: bump azure provider

* bump azure provider version

* [CLOUD-109] Integrar GKE como nuevo provider (kubernetes-sigs#320)

* Initial gke support

* Fix gcr authentication

* Minor fixes

* Fix gcr authentication

* Enable machine pools for gke

* Enable gke in capg

* Add google artifact registry support

* Add gke version validation

* Improve error message

* Update cluster-operator version

* Fix gke install logic

* Improve execute command retries (kubernetes-sigs#298)

* Improve execute command retries

* Fix kubeconfig condition

* Fix ecr login when ecr is in another region

* Remove comment

* [BUILD] 0.17.0-0.3.0: New pre-release

* Prepare for next version: 0.17.0-0.3.0-SNAPSHOT

* Prepare for next version: 0.17.0-0.3.1-SNAPSHOT

* Improve retry logic

---------

Co-authored-by: stratiocommit <stratiocommit@stratio.com>

* Feature/add infra validations (kubernetes-sigs#335)

* version v0.18.0-alpha

* update docs for v0.17.0

* fix kind version in readme

* comments-update-buildcontext

* Added validations for azs, k8sVersion, vpcs and subnets in each provider

* fixing dependency bugs

* Merge with master

* fixed gcp

* Update pkg/cluster/internal/validate/gcp.go

Co-authored-by: esierra-stratio <102975650+esierra-stratio@users.noreply.github.com>

* fixed build

* Update CHANGELOG.md

---------

Co-authored-by: Benjamin Elder <bentheelder@google.com>
Co-authored-by: Daman <aroradaman@gmail.com>
Co-authored-by: Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com>
Co-authored-by: esierra-stratio <102975650+esierra-stratio@users.noreply.github.com>

* version v0.18.0-alpha

* delete unneeded files

* add CHANGELOG

---------

Co-authored-by: Francisco Augusto <faugusto@stratio.com>
Co-authored-by: stratiocommit <stratiocommit@stratio.com>
Co-authored-by: lreciomelero <120394823+lreciomelero@users.noreply.github.com>
Co-authored-by: Benjamin Elder <bentheelder@google.com>
Co-authored-by: Daman <aroradaman@gmail.com>
Co-authored-by: Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants