switch off of the bazel debs #335

BenTheElder · 2019-02-23T13:25:31Z

easiest answer to fixing the bazel build after cross compliation landed.
/hold

positive:

the bazel build and the non-bazel build have the same install process now
we can probably refactor the build to only COPY operations and support cross-compilation Support arm64 #166
no longer broken by changes to the debs, the binaries are less in-flux

negative:

no longer installing the debs

k8s-ci-robot · 2019-02-23T13:25:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [BenTheElder]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

BenTheElder · 2019-02-23T14:09:08Z

all the builds passed this time, pushing a slight cleanup / refactor

BenTheElder · 2019-02-23T14:09:36Z

/hold cancel
/kind bug
/priority critical-urgent

BenTheElder · 2019-02-23T14:12:54Z

pkg/build/kube/bazelbuildbits.go

-	if err := install.Run("/bin/sh", "-c", "dpkg -i "+debs); err != nil {
-		log.Errorf("Debian install failed! %v", err)
-		return err
+	kindBinDir := path.Join(install.BasePath(), "bin")


this is the install logic from the make/bash/docker build, they match now

pkg/build/kube/bazelbuildbits.go

munnerz · 2019-02-23T14:18:13Z

pkg/build/kube/bazelbuildbits.go

-		filepath.Join(buildDir, "debs", "kubelet.deb"):        "debs/kubelet.deb",
-		filepath.Join(buildDir, "debs", "kubectl.deb"):        "debs/kubectl.deb",
-		filepath.Join(buildDir, "debs", "kubernetes-cni.deb"): "debs/kubernetes-cni.deb",
-		filepath.Join(buildDir, "debs", "cri-tools.deb"):      "debs/cri-tools.deb",


How are cri-tools and kubernetes-cni now installed? Don't see any references to them elsewhere 🙄

they're installed in the base image, this is now on par with the make/bash/docker build.

these debs just wrap downloading a copy of a stable release of these based on WORKSPACE, we do ~the same in the base image already.

or rather CNI is:

kind/images/base/Dockerfile

Lines 82 to 92 in 6f430d3

# Install CNI binaries to /opt/cni/bin

# TODO(bentheelder): doc why / what here

ARG CNI_VERSION="0.6.0"

ARG CNI_TARBALL="cni-plugins-${ARCH}-v${CNI_VERSION}.tgz"

ARG CNI_BASE_URL="https://storage.googleapis.com/kubernetes-release/network-plugins/"

ARG CNI_URL="${CNI_BASE_URL}${CNI_TARBALL}"

RUN curl -sSL --retry 5 --output /tmp/cni.tgz "${CNI_URL}" \

&& sha256sum /tmp/cni.tgz \

&& mkdir -p /opt/cni/bin \

&& tar -C /opt/cni/bin -xzf /tmp/cni.tgz \

&& rm -rf /tmp/cni.tgz

but cri-tools was only to satisfy the deb install requirements, we don't use those while we're on the dockershim path.

if/when we take a poke at CRI path we can install these to the base image, they have stable releases and don't change often in the kubernetes WORKSPACE, and IIRC are backwards/forwards compatible.

munnerz · 2019-02-23T14:25:07Z

/lgtm

tao12345666333 · 2019-02-23T14:27:42Z

/lgtm

BenTheElder · 2019-02-23T14:31:03Z

all of the builds passed again, so we're just waiting for the e2es 😅

* version v0.18.0-alpha * update docs for v0.17.0 * fix kind version in readme * comments-update-buildcontext * Added validations for azs, k8sVersion, vpcs and subnets in each provider * fixing dependency bugs * Merge with master * fixed gcp * Update pkg/cluster/internal/validate/gcp.go Co-authored-by: esierra-stratio <102975650+esierra-stratio@users.noreply.github.com> * fixed build * Update CHANGELOG.md --------- Co-authored-by: Benjamin Elder <bentheelder@google.com> Co-authored-by: Daman <aroradaman@gmail.com> Co-authored-by: Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com> Co-authored-by: esierra-stratio <102975650+esierra-stratio@users.noreply.github.com>

* chore: bump azure provider * bump azure provider version * [CLOUD-109] Integrar GKE como nuevo provider (kubernetes-sigs#320) * Initial gke support * Fix gcr authentication * Minor fixes * Fix gcr authentication * Enable machine pools for gke * Enable gke in capg * Add google artifact registry support * Add gke version validation * Improve error message * Update cluster-operator version * Fix gke install logic * Improve execute command retries (kubernetes-sigs#298) * Improve execute command retries * Fix kubeconfig condition * Fix ecr login when ecr is in another region * Remove comment * [BUILD] 0.17.0-0.3.0: New pre-release * Prepare for next version: 0.17.0-0.3.0-SNAPSHOT * Prepare for next version: 0.17.0-0.3.1-SNAPSHOT * Improve retry logic --------- Co-authored-by: stratiocommit <stratiocommit@stratio.com> * Feature/add infra validations (kubernetes-sigs#335) * version v0.18.0-alpha * update docs for v0.17.0 * fix kind version in readme * comments-update-buildcontext * Added validations for azs, k8sVersion, vpcs and subnets in each provider * fixing dependency bugs * Merge with master * fixed gcp * Update pkg/cluster/internal/validate/gcp.go Co-authored-by: esierra-stratio <102975650+esierra-stratio@users.noreply.github.com> * fixed build * Update CHANGELOG.md --------- Co-authored-by: Benjamin Elder <bentheelder@google.com> Co-authored-by: Daman <aroradaman@gmail.com> Co-authored-by: Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com> Co-authored-by: esierra-stratio <102975650+esierra-stratio@users.noreply.github.com> * version v0.18.0-alpha * delete unneeded files * add CHANGELOG --------- Co-authored-by: Francisco Augusto <faugusto@stratio.com> Co-authored-by: stratiocommit <stratiocommit@stratio.com> Co-authored-by: lreciomelero <120394823+lreciomelero@users.noreply.github.com> Co-authored-by: Benjamin Elder <bentheelder@google.com> Co-authored-by: Daman <aroradaman@gmail.com> Co-authored-by: Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com>

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2019

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 23, 2019

k8s-ci-robot requested review from amwat and munnerz February 23, 2019 13:25

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 23, 2019

BenTheElder force-pushed the fix-the-build branch from 3061d6c to e43cdf2 Compare February 23, 2019 13:31

BenTheElder mentioned this pull request Feb 23, 2019

jobs are broken on kubernetes master (build) #336

Closed

BenTheElder force-pushed the fix-the-build branch from e43cdf2 to 5e8627c Compare February 23, 2019 13:59

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2019

BenTheElder force-pushed the fix-the-build branch from 5e8627c to c1af70b Compare February 23, 2019 14:09

BenTheElder commented Feb 23, 2019

View reviewed changes

munnerz reviewed Feb 23, 2019

View reviewed changes

pkg/build/kube/bazelbuildbits.go Show resolved Hide resolved

munnerz reviewed Feb 23, 2019

View reviewed changes

pkg/build/kube/bazelbuildbits.go Outdated Show resolved Hide resolved

BenTheElder commented Feb 23, 2019

View reviewed changes

pkg/build/kube/bazelbuildbits.go Outdated Show resolved Hide resolved

munnerz reviewed Feb 23, 2019

View reviewed changes

pkg/build/kube/bazelbuildbits.go Show resolved Hide resolved

BenTheElder force-pushed the fix-the-build branch from c1af70b to 7bb6beb Compare February 23, 2019 14:14

switch off of the bazel debs and fix paths

cac4a6e

BenTheElder force-pushed the fix-the-build branch from 7bb6beb to cac4a6e Compare February 23, 2019 14:17

munnerz reviewed Feb 23, 2019

View reviewed changes

alejandrox1 mentioned this pull request Feb 23, 2019

Remove ARCH specific apt repo info to enable arm support #320

Closed

k8s-ci-robot assigned munnerz Feb 23, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2019

k8s-ci-robot assigned tao12345666333 Feb 23, 2019

k8s-ci-robot merged commit c64da77 into kubernetes-sigs:master Feb 23, 2019

BenTheElder deleted the fix-the-build branch February 23, 2019 14:54

BenTheElder mentioned this pull request Feb 23, 2019

bazel: initial support for cross-compilation kubernetes/kubernetes#73930

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

switch off of the bazel debs #335

switch off of the bazel debs #335

BenTheElder commented Feb 23, 2019

k8s-ci-robot commented Feb 23, 2019

BenTheElder commented Feb 23, 2019

BenTheElder commented Feb 23, 2019

BenTheElder Feb 23, 2019 •

edited

Loading

munnerz Feb 23, 2019

BenTheElder Feb 23, 2019

BenTheElder Feb 23, 2019

BenTheElder Feb 23, 2019 •

edited

Loading

munnerz commented Feb 23, 2019

tao12345666333 commented Feb 23, 2019

BenTheElder commented Feb 23, 2019

	# Install CNI binaries to /opt/cni/bin
	# TODO(bentheelder): doc why / what here
	ARG CNI_VERSION="0.6.0"
	ARG CNI_TARBALL="cni-plugins-${ARCH}-v${CNI_VERSION}.tgz"
	ARG CNI_BASE_URL="https://storage.googleapis.com/kubernetes-release/network-plugins/"
	ARG CNI_URL="${CNI_BASE_URL}${CNI_TARBALL}"
	RUN curl -sSL --retry 5 --output /tmp/cni.tgz "${CNI_URL}" \
	&& sha256sum /tmp/cni.tgz \
	&& mkdir -p /opt/cni/bin \
	&& tar -C /opt/cni/bin -xzf /tmp/cni.tgz \
	&& rm -rf /tmp/cni.tgz

switch off of the bazel debs #335

switch off of the bazel debs #335

Conversation

BenTheElder commented Feb 23, 2019

k8s-ci-robot commented Feb 23, 2019

BenTheElder commented Feb 23, 2019

BenTheElder commented Feb 23, 2019

BenTheElder Feb 23, 2019 • edited Loading

Choose a reason for hiding this comment

munnerz Feb 23, 2019

Choose a reason for hiding this comment

BenTheElder Feb 23, 2019

Choose a reason for hiding this comment

BenTheElder Feb 23, 2019

Choose a reason for hiding this comment

BenTheElder Feb 23, 2019 • edited Loading

Choose a reason for hiding this comment

munnerz commented Feb 23, 2019

tao12345666333 commented Feb 23, 2019

BenTheElder commented Feb 23, 2019

BenTheElder Feb 23, 2019 •

edited

Loading

BenTheElder Feb 23, 2019 •

edited

Loading