-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump haproxy, kindnetd, local-path, base image #3213
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
might be best to just wait and get all of these re-bumped, there's also a CNI plugins update available and we just changed the builds again for kindnetd and local-path-provisioner in #3214 |
filed #3215 |
is this with the latest images? |
uh oh
|
fun :-) |
I'm bisecting the changes, locally building just for amd64 and testing which commits work and don.t 5890ae9 works for building an image and booting a cluster locally at least, for me locally actually the containerd teardown at image build time is broken on the image in this PR |
yes this also happens in CI |
5890ae9..main only has the distro / cross build change, could be either the cross build or the distro change |
With this patch (breaks cross-building but can be built with diff --git a/images/base/Dockerfile b/images/base/Dockerfile
index 1bb8d929..041182db 100644
--- a/images/base/Dockerfile
+++ b/images/base/Dockerfile
@@ -20,7 +20,7 @@
# start from ubuntu, this image is reasonably small as a starting point
# for a kubernetes node image, it doesn't contain much we don't need
# this stage will install basic files and packages
-ARG BASE_IMAGE=debian:bullseye-slim
+ARG BASE_IMAGE=ubuntu:22.04
FROM $BASE_IMAGE as base
# copy in static files
@@ -98,10 +98,9 @@ COPY --chmod=0755 scripts/third_party/gimme/gimme /usr/local/bin/
COPY --chmod=0755 scripts/target-cc /usr/local/bin/
# tools needed at build-time only
# first ensure we can install packages for both architectures
-RUN dpkg --add-architecture arm64 && dpkg --add-architecture amd64 \
- && clean-install bash ca-certificates curl git make pkg-config \
- crossbuild-essential-amd64 crossbuild-essential-arm64 \
- libseccomp-dev:amd64 libseccomp-dev:arm64
+RUN clean-install bash ca-certificates curl git make pkg-config \
+ build-essential \
+ libseccomp-dev
# set by makefile to .go-version
ARG GO_VERSION
RUN eval "$(gimme "${GO_VERSION}")" \ I can build an image and create a cluster. So that points to the distro differences rather than the build process differences. |
ah, well that's a gap .. |
I think that's it for the breaking change, just the lack of procps, adding procps results in a functioning node image build. I'm going to do some more checking though. |
I've rebased this to all updated images following #3218 |
It works for me locally, but my local dev machine is on cgroup v2 |
rebased with #3220 |
/lgtm |
bumps all of the images recently updated to their latest builds