Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump haproxy, kindnetd, local-path, base image #3213

Merged
merged 4 commits into from
May 12, 2023

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented May 10, 2023

bumps all of the images recently updated to their latest builds

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 10, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 10, 2023
@aojea
Copy link
Contributor

aojea commented May 10, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 10, 2023
@BenTheElder BenTheElder changed the title bump haproxy, kindnetd, local-path bump haproxy, kindnetd, local-path, base image May 11, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2023
@BenTheElder
Copy link
Member Author

might be best to just wait and get all of these re-bumped, there's also a CNI plugins update available and we just changed the builds again for kindnetd and local-path-provisioner in #3214

@BenTheElder
Copy link
Member Author

filed #3215

@aojea
Copy link
Contributor

aojea commented May 11, 2023

is this with the latest images?

@aojea
Copy link
Contributor

aojea commented May 11, 2023

uh oh

stderr:
error: Internal error occurred: error executing command in container: failed to exec in container: failed to start exec "6be0368be0f6208c997a5a4271766e57b99267da6900bdd3ee89acdc2ce9d9b4": OCI runtime exec failed: exec failed: unable to start container process: error adding pid 37543 to cgroups: failed to write 37543: openat2 /sys/fs/cgroup/unified/kubelet.slice/kubelet-kubepods.slice/kubelet-kubepods-besteffort.slice/kubelet-kubepods-besteffort-podc9cb3b02_abb6_4dec_baef_3f148adca41f.slice/cri-containerd-8c2d29c232674cfcb3cc6225e1dbcdcf889f8850d1f2b9dfa861fa00982521f8.scope/cgroup.procs: no such file or directory: unknown

@BenTheElder
Copy link
Member Author

fun :-)

@BenTheElder
Copy link
Member Author

BenTheElder commented May 11, 2023

I'm bisecting the changes, locally building just for amd64 and testing which commits work and don.t

5890ae9 works for building an image and booting a cluster locally at least, for me locally actually the containerd teardown at image build time is broken on the image in this PR

@BenTheElder
Copy link
Member Author

Image build Failed! Failed to tear down containerd after loading images command "docker exec --privileged kind-build-1683789384-46462532 pkill containerd" failed with error: exit status 126

yes this also happens in CI

@BenTheElder
Copy link
Member Author

BenTheElder commented May 11, 2023

5890ae9..main only has the distro / cross build change, could be either the cross build or the distro change

@BenTheElder
Copy link
Member Author

With this patch (breaks cross-building but can be built with make -C images/base quick just for the host platform)

diff --git a/images/base/Dockerfile b/images/base/Dockerfile
index 1bb8d929..041182db 100644
--- a/images/base/Dockerfile
+++ b/images/base/Dockerfile
@@ -20,7 +20,7 @@
 # start from ubuntu, this image is reasonably small as a starting point
 # for a kubernetes node image, it doesn't contain much we don't need
 # this stage will install basic files and packages
-ARG BASE_IMAGE=debian:bullseye-slim
+ARG BASE_IMAGE=ubuntu:22.04
 FROM $BASE_IMAGE as base
 
 # copy in static files
@@ -98,10 +98,9 @@ COPY --chmod=0755 scripts/third_party/gimme/gimme /usr/local/bin/
 COPY --chmod=0755 scripts/target-cc /usr/local/bin/
 # tools needed at build-time only
 # first ensure we can install packages for both architectures
-RUN dpkg --add-architecture arm64 && dpkg --add-architecture amd64 \
-    && clean-install bash ca-certificates curl git make pkg-config \
-    crossbuild-essential-amd64 crossbuild-essential-arm64 \
-    libseccomp-dev:amd64 libseccomp-dev:arm64
+RUN clean-install bash ca-certificates curl git make pkg-config \
+    build-essential \
+    libseccomp-dev
 # set by makefile to .go-version
 ARG GO_VERSION
 RUN eval "$(gimme "${GO_VERSION}")" \

I can build an image and create a cluster. So that points to the distro differences rather than the build process differences.

@BenTheElder
Copy link
Member Author

OCI runtime exec failed: exec failed: unable to start container process: exec: "pkill": executable file not found in $PATH: unknown

ah, well that's a gap ..

@BenTheElder
Copy link
Member Author

I think that's it for the breaking change, just the lack of procps, adding procps results in a functioning node image build.

I'm going to do some more checking though.

@BenTheElder
Copy link
Member Author

I've rebased this to all updated images following #3218

@BenTheElder
Copy link
Member Author

It works for me locally, but my local dev machine is on cgroup v2

@BenTheElder
Copy link
Member Author

rebased with #3220

@aojea
Copy link
Contributor

aojea commented May 12, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5130316 into kubernetes-sigs:main May 12, 2023
@BenTheElder BenTheElder deleted the image-bumps branch May 12, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants