roll back runc to 1.1.5 #3220
Merged
roll back runc to 1.1.5 #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
BenTheElder
commented
May 12, 2023
| @@ -128,7 +128,7 @@ RUN git clone --filter=tree:0 "${CONTAINERD_CLONE_URL}" /containerd \ | |||
| # stage for building runc | |||
| FROM go-build as build-runc | |||
| ARG TARGETARCH GO_VERSION | |||
| ARG RUNC_VERSION="v1.1.7" | |||
| ARG RUNC_VERSION="v1.1.5" | |||
There was a problem hiding this comment.
per recent discussion: it's acceptable to have an older runc than the vendored copy in kubelet, but being ahead can cause problems on cgroups v1
so we're going to an older version, this is still new enough to have the recent CVE patches.
thankfully runc version is independent of containerd version in the base image now, so we can avoid rolling back containerd
This was referenced May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see:
#3219 (comment)
https://kubernetes.slack.com/archives/CEKK1KTN2/p1683851267796889
opencontainers/runc#3849