Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roll back runc to 1.1.5 #3220

Merged
merged 1 commit into from
May 12, 2023
Merged

roll back runc to 1.1.5 #3220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion images/base/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ RUN git clone --filter=tree:0 "${CONTAINERD_CLONE_URL}" /containerd \
# stage for building runc
FROM go-build as build-runc
ARG TARGETARCH GO_VERSION
ARG RUNC_VERSION="v1.1.7"
ARG RUNC_VERSION="v1.1.5"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per recent discussion: it's acceptable to have an older runc than the vendored copy in kubelet, but being ahead can cause problems on cgroups v1

so we're going to an older version, this is still new enough to have the recent CVE patches.

thankfully runc version is independent of containerd version in the base image now, so we can avoid rolling back containerd

ARG RUNC_CLONE_URL="https://github.com/opencontainers/runc"
RUN git clone --filter=tree:0 "${RUNC_CLONE_URL}" /runc \
&& cd /runc \
Expand Down