This repository has been archived by the owner on May 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 264
Examine all pending tasks in a job #540
Merged
k8s-ci-robot
merged 2 commits into
kubernetes-retired:master
from
Jeffwan:examine_all_tasks
Jan 7, 2019
Merged
Examine all pending tasks in a job #540
k8s-ci-robot
merged 2 commits into
kubernetes-retired:master
from
Jeffwan:examine_all_tasks
Jan 7, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
label
Jan 6, 2019
k8s-ci-robot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Jan 6, 2019
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan, k82cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Jan 7, 2019
BTW, please also add e2e test for this case :) |
/cc @jiaxuanzhou , would this be your case? |
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 7, 2019
…ase-0.3 Automated cherry pick of #540: Examine all pending tasks in one loop
@k82cn Sure. I will add an e2e test case for this change. |
Please refer to |
This was referenced Jan 7, 2019
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Examine all pending tasks in a job
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Examine all pending tasks in a job
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Examine all pending tasks in a job
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
Indicates that a PR is ready to be merged.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Process exit when it meet the first tasks that can not fit into node. This PR make sure it checks all pending tasks and try to fit them all into nodes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #537
Special notes for your reviewer:
if task is assigned, it add job into job list and rerun entire process.
If current task is not assigned, it won't step out. Instead, it will try to fit all rest tasks.
Release note: