-
Notifications
You must be signed in to change notification settings - Fork 1.6k
🌱 (CLI): Add unit tests and improve coverage for plugins/golang pkg #4959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
k8s-ci-robot
merged 1 commit into
kubernetes-sigs:master
from
mayuka-c:issue-4925-part4
Jul 24, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| /* | ||
| Copyright 2025 The Kubernetes Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package golang | ||
|
|
||
| import ( | ||
| "os" | ||
|
|
||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
| ) | ||
|
|
||
| var _ = Describe("golang:repository", func() { | ||
| var ( | ||
| tmpDir string | ||
| oldDir string | ||
| ) | ||
|
|
||
| BeforeEach(func() { | ||
| var err error | ||
| tmpDir, err = os.MkdirTemp("", "repo-test") | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| oldDir, err = os.Getwd() | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(os.Chdir(tmpDir)).To(Succeed()) | ||
| }) | ||
|
|
||
| AfterEach(func() { | ||
| Expect(os.Chdir(oldDir)).To(Succeed()) | ||
| Expect(os.RemoveAll(tmpDir)).To(Succeed()) | ||
| }) | ||
|
|
||
| When("go.mod exists", func() { | ||
| BeforeEach(func() { | ||
| // Simulate `go mod edit -json` output by writing a go.mod file and using go commands | ||
| Expect(os.WriteFile("go.mod", []byte("module github.com/example/repo\n"), 0o644)).To(Succeed()) | ||
| }) | ||
|
|
||
| It("findGoModulePath returns the module path", func() { | ||
| path, err := findGoModulePath() | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(path).To(Equal("github.com/example/repo")) | ||
| }) | ||
|
|
||
| It("FindCurrentRepo returns the module path", func() { | ||
| path, err := FindCurrentRepo() | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(path).To(Equal("github.com/example/repo")) | ||
| }) | ||
| }) | ||
|
|
||
| When("go.mod does not exist", func() { | ||
| It("findGoModulePath returns error", func() { | ||
| got, err := findGoModulePath() | ||
| Expect(err).To(HaveOccurred()) | ||
| Expect(got).To(Equal("")) | ||
| }) | ||
|
|
||
| It("FindCurrentRepo tries to init a module and returns the path or a helpful error", func() { | ||
| path, err := FindCurrentRepo() | ||
| if err != nil { | ||
| Expect(path).To(Equal("")) | ||
| Expect(err.Error()).To(ContainSubstring("could not determine repository path")) | ||
| } else { | ||
| Expect(path).NotTo(BeEmpty()) | ||
| } | ||
| }) | ||
| }) | ||
|
|
||
| When("go mod command fails with exec.ExitError", func() { | ||
| var origPath string | ||
|
|
||
| BeforeEach(func() { | ||
| // Move go binary out of PATH to force exec error | ||
| origPath = os.Getenv("PATH") | ||
| // Set PATH to empty so "go" cannot be found | ||
| Expect(os.Setenv("PATH", "")).To(Succeed()) | ||
| }) | ||
|
|
||
| AfterEach(func() { | ||
| Expect(os.Setenv("PATH", origPath)).To(Succeed()) | ||
| }) | ||
|
|
||
| It("findGoModulePath returns error with stderr message", func() { | ||
| got, err := findGoModulePath() | ||
| Expect(err).To(HaveOccurred()) | ||
| Expect(err.Error()).NotTo(BeEmpty()) | ||
| Expect(got).To(Equal("")) | ||
| }) | ||
|
|
||
| It("FindCurrentRepo returns error with stderr message", func() { | ||
| got, err := FindCurrentRepo() | ||
| Expect(err).To(HaveOccurred()) | ||
| Expect(err.Error()).To(ContainSubstring("could not determine repository path")) | ||
| Expect(got).To(Equal("")) | ||
| }) | ||
| }) | ||
| }) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to cover those options
To know more about see: https://kubebuilder.io/reference/using_an_external_resource
Also, you can check sample values in testdata samples like:
https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4/PROJECT#L66C1-L79C14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we can do that in follow ups :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure @camilamacedo86 I will take look into this :-)