Revert "implement download mirrors support (#8474)" #10884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/M
This reverts commit c6e5314. There is no user of the download mirrors support in kubespray, for a long time.
VannTen
force-pushed
the
cleanup/remove_mirrors_support
branch
from
06a1c55 to
7efe04a
Compare
|
Thanks @VannTen |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cc @MrFreezeex |
|
Thanks for the cleanup 🙏 |
k8s-ci-robot
added
the
lgtm
dibi-codes
pushed a commit
to fino-digital/kubespray
that referenced
this pull request
May 7, 2024
…ubernetes-sigs#10884) This reverts commit c6e5314. There is no user of the download mirrors support in kubespray, for a long time.
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
…ubernetes-sigs#10884) This reverts commit c6e5314. There is no user of the download mirrors support in kubespray, for a long time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Revert #8474
There is no user of the download mirrors support in kubespray, for a long time.
So remove it, one less thing that can go wrong.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: