implement download mirrors support #8474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
cristicalin
force-pushed
the
download_file_mirrors
branch
3 times, most recently
from
2ec7151
to
575439f
Compare
cristicalin
force-pushed
the
download_file_mirrors
branch
from
575439f
to
bde6a1b
Compare
floryut
approved these changes
Feb 7, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
oomichi
reviewed
Feb 7, 2022
There was a problem hiding this comment.
Thanks for doing this @cristicalin
That seems good for me, just one question.
| @@ -47,11 +47,40 @@ | |||
| - download_force_cache | |||
| - not download_localhost | |||
|
|
|||
| # We check a number of mirrors that may hold the file and pick a working one at random | |||
| # This task will avoid logging it's parameters to not leak environment passwords in the log | |||
There was a problem hiding this comment.
Is it possible to see which URL doesn't work to know the URL needs to be updated?
There was a problem hiding this comment.
Not with the current logic since we put the no_log flag on the download task, the error is obscured, including any parameters like the URL. I could add a second task to log the results though that also has some potential to leak credentials if they are embedded in the url.
There was a problem hiding this comment.
OK.
It is fine to go with current one.
When facing a maintenance issue, we will be able to add some log to know which URLs got old.
/lgtm
k8s-ci-robot
added
the
lgtm
Quehenr
pushed a commit
to Quehenr/unstable-laboratory-infrastructure-kubespray
that referenced
this pull request
Feb 18, 2022
* master: Configure Etcd container_manager explicitly (kubernetes-sigs#8521) Fix print_hostnames of inventory.py (kubernetes-sigs#8554) Fix etcd_events not getting upgraded in upgrade-cluster.yml (kubernetes-sigs#8550) nerdctl: upgrade to 0.16.1 (kubernetes-sigs#8539) Allow pausing after upgrade but before uncordon (kubernetes-sigs#8530) [calico] upgrade release checksums (kubernetes-sigs#8544) Allow to specify a source address for metallb peerings, and target only some nodes using node selectors (kubernetes-sigs#8534) add support for Dual Stack node InternalIP (kubernetes-sigs#8542) terraform/gcp: Allow to change extra disk types (kubernetes-sigs#8524) add support for Calico IP6_AUTODETECTION_METHOD (kubernetes-sigs#8541) implement download mirrors support (kubernetes-sigs#8474) Fix: Error when creating subnets more than AZ (kubernetes-sigs#8516) feat(offline): Improve generate_list.sh to generate offline file list using ansible (kubernetes-sigs#8537) (kubernetes-sigs#8538) docs: Update offline-environment.md for containerd (kubernetes-sigs#8520) (kubernetes-sigs#8523) Change Cilium setting identity_allocation_mode to cilium_identity_allocation_mode (kubernetes-sigs#8519) Fix wrong port name in metallb.yml.j2 (kubernetes-sigs#8510)
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
* [download] add mechanism to support mirrors * [calico] support alternate download url
Closed
|
@cristicalin The older url is now 404 (see #8915). |
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jun 29, 2023
* [download] add mechanism to support mirrors * [calico] support alternate download url
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Oct 21, 2023
* [download] add mechanism to support mirrors * [calico] support alternate download url
VannTen
added a commit
to VannTen/kubespray
that referenced
this pull request
Feb 5, 2024
This reverts commit c6e5314. There is no user of the download mirrors support in kubespray, for a long time.
VannTen
added a commit
to VannTen/kubespray
that referenced
this pull request
Feb 5, 2024
This reverts commit c6e5314. There is no user of the download mirrors support in kubespray, for a long time.
k8s-ci-robot
pushed a commit
that referenced
this pull request
Feb 6, 2024
dibi-codes
pushed a commit
to fino-digital/kubespray
that referenced
this pull request
May 7, 2024
…ubernetes-sigs#10884) This reverts commit c6e5314. There is no user of the download mirrors support in kubespray, for a long time.
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
…ubernetes-sigs#10884) This reverts commit c6e5314. There is no user of the download mirrors support in kubespray, for a long time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR implements a mechanism to download files from alternate locations if possible. The functionality is added to the download role to support a
mirrorskey in thedownloadsdict which will be used to select a viable mirror. The actual mirror to be used during the download is selected as a random choice between all valid mirrors.Since calico is publishing their artifacts in multiple locations, this PR implements a sample
mirrorsconfiguration forcalicoctldownload location.Which issue(s) this PR fixes:
Fixes #8427
Special notes for your reviewer:
Does this PR introduce a user-facing change?: