Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Cilium setting identity_allocation_mode to cilium_identity_allocation_mode #8519

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Change Cilium setting identity_allocation_mode to cilium_identity_allocation_mode #8519

merged 2 commits into from
Feb 8, 2022

Conversation

tomberget
Copy link
Contributor

@tomberget tomberget commented Feb 8, 2022 •
edited by floryut
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Rename the Cilium setting identity_allocation_mode to cilium_identity_allocation_mode to keep it in line with the rest of the settings.

Also, add some documentation where the crd option is used.

Which issue(s) this PR fixes:

Fixes #8517

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[Cilium] Change Cilium setting identity_allocation_mode to cilium_identity_allocation_mode (⚠️ ADD NOTE: If the Cilium setting `identity_allocation_mode` has been overridden locally, it needs to be changed to `cilium_identity_allocation_mode`.)

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @tomberget. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from EppO and jayonlau February 8, 2022 16:01
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 8, 2022
@tomberget
Copy link
Contributor Author

@floryut recreated the issue here. At least now the CLA check is ok :)

floryut
floryut approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomberget 👍
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, tomberget

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2022
@oomichi
Copy link
Contributor

oomichi commented Feb 8, 2022

I had a concern if renaming the option due to backward incompatible change for users.
But the option identity_allocation_mode has been added after v2.18.0 which is the latest stable version.
So it is fine to rename the option at this time I think.

One thing is inventory/sample/group_vars/k8s_cluster/k8s-net-cilium.yml contains the option, it is necessary to rename it.

/cc @oomichi

@k8s-ci-robot k8s-ci-robot requested a review from oomichi February 8, 2022 17:38
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2022
@tomberget
Copy link
Contributor Author

I had a concern if renaming the option due to backward incompatible change for users. But the option identity_allocation_mode has been added after v2.18.0 which is the latest stable version. So it is fine to rename the option at this time I think.

One thing is inventory/sample/group_vars/k8s_cluster/k8s-net-cilium.yml contains the option, it is necessary to rename it.

/cc @oomichi

Added the change to the sample file as well.

@oomichi
Copy link
Contributor

oomichi commented Feb 8, 2022

Thanks for updating. now looks good for me.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 84b9309 into kubernetes-sigs:master Feb 8, 2022
@tomberget tomberget deleted the improve/cilium_identity_allocation_mode2 branch February 8, 2022 22:56
Quehenr pushed a commit to Quehenr/unstable-laboratory-infrastructure-kubespray that referenced this pull request Feb 18, 2022
Merge branch 'master' into feature/virtualbox
6fceccf 
* master:
  Configure Etcd container_manager explicitly (kubernetes-sigs#8521)
  Fix print_hostnames of inventory.py (kubernetes-sigs#8554)
  Fix etcd_events not getting upgraded in upgrade-cluster.yml (kubernetes-sigs#8550)
  nerdctl: upgrade to 0.16.1 (kubernetes-sigs#8539)
  Allow pausing after upgrade but before uncordon (kubernetes-sigs#8530)
  [calico] upgrade release checksums (kubernetes-sigs#8544)
  Allow to specify a source address for metallb peerings, and target only some nodes using node selectors (kubernetes-sigs#8534)
  add support for Dual Stack node InternalIP (kubernetes-sigs#8542)
  terraform/gcp: Allow to change extra disk types (kubernetes-sigs#8524)
  add support for Calico IP6_AUTODETECTION_METHOD (kubernetes-sigs#8541)
  implement download mirrors support (kubernetes-sigs#8474)
  Fix: Error when creating subnets more than AZ (kubernetes-sigs#8516)
  feat(offline): Improve generate_list.sh to generate offline file list using ansible (kubernetes-sigs#8537) (kubernetes-sigs#8538)
  docs: Update offline-environment.md for containerd (kubernetes-sigs#8520) (kubernetes-sigs#8523)
  Change Cilium setting identity_allocation_mode to cilium_identity_allocation_mode (kubernetes-sigs#8519)
  Fix wrong port name in metallb.yml.j2 (kubernetes-sigs#8510)
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@sakuraiyuta
Change Cilium setting identity_allocation_mode to cilium_identity_all…
318e574 
…ocation_mode (kubernetes-sigs#8519)

* Change Cilium identity_allocation_mode to cilium_identity_allocation_mode

* Change inventory sample
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
@floryut floryut added kind/network Network section in the release note and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 1, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@LuckySB
Change Cilium setting identity_allocation_mode to cilium_identity_all…
b79cad2 
…ocation_mode (kubernetes-sigs#8519)

* Change Cilium identity_allocation_mode to cilium_identity_allocation_mode

* Change inventory sample
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 21, 2023
@LuckySB
Change Cilium setting identity_allocation_mode to cilium_identity_all…
2a21fc2 
…ocation_mode (kubernetes-sigs#8519)

* Change Cilium identity_allocation_mode to cilium_identity_allocation_mode

* Change inventory sample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@EppO EppO Awaiting requested review from EppO

@jayonlau jayonlau Awaiting requested review from jayonlau

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/network Network section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for defining identity-allocation-mode for the Cilium CNI
4 participants
@tomberget @k8s-ci-robot @oomichi @floryut