Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use latest calicoctl repo first #8920

Merged
merged 1 commit into from
Jun 9, 2022
Merged

use latest calicoctl repo first #8920

merged 1 commit into from
Jun 9, 2022

Conversation

sathieu
Copy link
Contributor

@sathieu sathieu commented Jun 3, 2022 •
edited by floryut
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

offline mode ./generate_list.sh is only using the primary url, which is 404 before this PR. Without offline mode, the problem is hidden by Validate mirrors tasks (see #8474)

Which issue(s) this PR fixes:
Fixes #8915

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Swap calico download url, as the old primary url was deprecated and artefact no longer published

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @sathieu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sathieu sathieu mentioned this pull request Jun 3, 2022
Closed
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2022
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO June 3, 2022 07:28
@sathieu
Copy link
Contributor Author

sathieu commented Jun 3, 2022

/assign @LuckySB

floryut
floryut approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sathieu Thanks 👍
Indeed https://github.com/projectcalico/calicoctl is archived and no longer updated

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, sathieu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2022
@sathieu
Copy link
Contributor Author

sathieu commented Jun 3, 2022

@floryut ok-to-test is missing ...

@floryut
Copy link
Member

floryut commented Jun 3, 2022

@floryut ok-to-test is missing ...

lgtm too, no rush needed 😄
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2022
@sathieu
Copy link
Contributor Author

sathieu commented Jun 3, 2022

@floryut Yes, sorry for the noise (I thought you forgot).

cristicalin
cristicalin reviewed Jun 5, 2022
View reviewed changes
roles/download/defaults/main.yml
@@ -142,8 +142,7 @@ kubectl_download_url: "https://storage.googleapis.com/kubernetes-release/release
kubeadm_download_url: "https://storage.googleapis.com/kubernetes-release/release/{{ kubeadm_version }}/bin/linux/{{ image_arch }}/kubeadm"
etcd_download_url: "https://github.com/etcd-io/etcd/releases/download/{{ etcd_version }}/etcd-{{ etcd_version }}-linux-{{ image_arch }}.tar.gz"
cni_download_url: "https://github.com/containernetworking/plugins/releases/download/{{ cni_version }}/cni-plugins-linux-{{ image_arch }}-{{ cni_version }}.tgz"
calicoctl_download_url: "https://github.com/projectcalico/calicoctl/releases/download/{{ calico_ctl_version }}/calicoctl-linux-{{ image_arch }}"
Copy link
Contributor

@cristicalin cristicalin Jun 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting this breaks older versions of calico because project calico did this in the middle of a release stream and have not provided redirects from the old urls or any other compatibility mechanism.

We should swap the urls between the old and the new ones to unbreak the offline download but until we remove all older versions that kubespray supports we cannot do this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swapped the urls.

@cristicalin
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2022
@sathieu sathieu changed the title calicoctl repo has been merged in calico use latest calicoctl repo first Jun 8, 2022
@sathieu
Copy link
Contributor Author

sathieu commented Jun 8, 2022

@cristicalin I swapped the URLs instead. Back to you!

@floryut
Copy link
Member

floryut commented Jun 9, 2022

@cristicalin I swapped the URLs instead. Back to you!

👍
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2022
@cristicalin
Copy link
Contributor

Thanks @sathieu !

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit f53764f into kubernetes-sigs:master Jun 9, 2022
@floryut floryut added the kind/bug Categorizes issue or PR as related to a bug. label Jun 9, 2022
@oomichi oomichi mentioned this pull request Jun 13, 2022
Closed
oomichi pushed a commit to oomichi/kubespray that referenced this pull request Jun 13, 2022
@sathieu
calicoctl repo has been merged in calico (kubernetes-sigs#8920)
aaa2643
@oomichi oomichi mentioned this pull request Jun 13, 2022
Merged
k8s-ci-robot pushed a commit that referenced this pull request Jun 14, 2022
@oomichi @sathieu
calicoctl repo has been merged in calico (#8920) (#8972)
b4951da 
Co-authored-by: Mathieu Parent <mathieu.parent@insee.fr>
fungusakafungus pushed a commit to fungusakafungus/kubespray that referenced this pull request Jul 13, 2022
@sathieu @fungusakafungus
calicoctl repo has been merged in calico (kubernetes-sigs#8920)
c6dae5a
@floryut floryut mentioned this pull request Sep 19, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 1, 2023
@sathieu @LuckySB
calicoctl repo has been merged in calico (kubernetes-sigs#8920)
30c07df
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
@sathieu @LuckySB
calicoctl repo has been merged in calico (kubernetes-sigs#8920)
cf1e8cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristicalin cristicalin cristicalin left review comments

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@EppO EppO Awaiting requested review from EppO

Assignees

@cristicalin cristicalin

@LuckySB LuckySB

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing offline download file
5 participants
@sathieu @k8s-ci-robot @floryut @cristicalin @LuckySB