Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Proposal v2.20 #9291

Closed
floryut opened this issue Sep 19, 2022 · 19 comments
Closed

Release Proposal v2.20 #9291

floryut opened this issue Sep 19, 2022 · 19 comments

Comments

@floryut
Copy link
Member

floryut commented Sep 19, 2022

Deprecation / Removal

Feature / Major changes

Network

Applications

Container-Managers

Bug or Regression

Other (Cleanup or Flake)

Component versions:

  • Core
    • Kubernetes v1.24.6
    • Etcd v3.5.4
    • Docker v20.10
    • Containerd v1.6.8
    • CRI-O v1.24
  • Network
    • CNI-plugins v1.1.1
    • Calico v3.23.3
    • Cilium v1.12.1
    • Flannel v0.19.2
    • Kube-ovn v1.9.7
    • Kube-Router v1.5.1
    • Multus v3.8
    • Weave v2.8.1
    • kube-vip v0.4.2
  • App
    • Cert-manager v1.9.1
    • CoreDNS v1.8.6
    • Nginx-ingress v1.3.1
    • krew v0.4.3
    • argocd v2.4.12
    • helm v3.9.4
    • metallb v0.12.1
    • registry v2.8.1

Known issues

  • Host network might broke when an interface goes down (Cilium 1.12/Ubuntu 22.04), please read Note 5.
  • If bin_dir value is changed to something other than /usr/local/bin, containerd configuration might need to be tweak, please check Custom Binary directoy bin_dir bug #9243

Notes

  1. Upgrading the bootstrap pypy may cause some unexpected behaviors for Flatcar use-cases)
  2. As the newly added feature uses the default value of MetalLB as same, there is no side effect for users who do not change it's value
  3. This PR also implements cgroup auto-mount. By default, it is enabled. You can disable it by adding cgroup_auto_mount: false. Moreover, you can enable or disable BPF with these variables cilium_enable_bpf_masquerade and cilium_enable_host_legacy_routing
  4. Some old (<2020Y) 'Flatcar Container Linux by Kinvolk' may not be supported.
  5. With Cilium 1.12/Ubuntu 22.04, you might run into this issue, workaround are available while the issue is resolved on cilium end.
@krystianmlynek
Copy link
Contributor

krystianmlynek commented Sep 19, 2022

Should systemd-networkd issue that was mentioned in #9225 be listed in known issues? What do you think?

@floryut
Copy link
Member Author

floryut commented Sep 19, 2022

Should systemd-networkd issue that was mentioned in #9225 be listed in known issues? What do you think?

Thank you, you're right, I'll draft something up

@sohnaeo
Copy link

sohnaeo commented Sep 20, 2022

Should #9243 be listed in known_issues as well? users need to be warned if bin_dir is different than /usr/local/bin then need to add below into config.toml through containerd_extra_args

[plugins."io.containerd.internal.v1.opt"]
path = "/opt/mypath"

@floryut
Copy link
Member Author

floryut commented Sep 20, 2022

@sohnaeo done, thank you 👍

@fungusakafungus
Copy link
Contributor

Add variable to tweak the vsphere-csi namespace (vsphere_csi_namespace) (#9278, @MahdiAbbasi95)

is more dangerous than it sounds, new var defaults to new value, vmware-system-csi, and there's no code to remove vsphere csi driver from kube-system namespace, so if someone used it before, they'll either need to remove csi driver from kube-system or set vsphere_csi_namespace to kube-system

@oomichi
Copy link
Contributor

oomichi commented Sep 21, 2022

Thank you so much for preparing a new release @floryut !
The above release-note seems good for me.

+1

@mzaian
Copy link
Contributor

mzaian commented Sep 22, 2022

Hi @floryut
Would be nice If we can have this in the release #9302

@floryut
Copy link
Member Author

floryut commented Sep 22, 2022

Add variable to tweak the vsphere-csi namespace (vsphere_csi_namespace) (#9278, @MahdiAbbasi95)

is more dangerous than it sounds, new var defaults to new value, vmware-system-csi, and there's no code to remove vsphere csi driver from kube-system namespace, so if someone used it before, they'll either need to remove csi driver from kube-system or set vsphere_csi_namespace to kube-system

Created #9312 to address that

@floryut
Copy link
Member Author

floryut commented Sep 22, 2022

Hi @floryut Would be nice If we can have this in the release #9302

Approved, needs a reviewer to check this PR 👍

@yankay
Copy link
Member

yankay commented Sep 23, 2022

HI @floryut , I'm sorry for there is a typo:

Fix ETCD memory leak issue by adding max_concurrent=1000 in the CoreDNS config. (#9307, @yankay) =>

Fix CoreDNS memory leak issue by adding max_concurrent=1000 in the CoreDNS config. (#9307, @yankay) =>

Thanks.

@floryut
Copy link
Member Author

floryut commented Sep 23, 2022

HI @floryut , I'm sorry for there is a typo:

Fix ETCD memory leak issue by adding max_concurrent=1000 in the CoreDNS config. (#9307, @yankay) =>

Fix CoreDNS memory leak issue by adding max_concurrent=1000 in the CoreDNS config. (#9307, @yankay) =>

Thanks.

🤦 thank you

@fungusakafungus
Copy link
Contributor

I could reproduce #9019 and am working on a fix. It's mind-boggling.

@rptaylor
Copy link
Contributor

I could reproduce #9019 and am working on a fix. It's mind-boggling.

That looks serious, would be good to have a fix in 2.20 otherwise clusters could still have an old containerd version from 2.18.

@rptaylor
Copy link
Contributor

@floryut what about including #9026 , #9109?

@floryut
Copy link
Member Author

floryut commented Sep 24, 2022

@floryut what about including #9026 , #9109?

Don't forget to fill the Does this PR introduce a user-facing change? this is what generate the release notes (I try to edit them but sometime I can miss a few PR).

Anyway, I've added the PR in the release note, thank you.

@HoKim98
Copy link
Contributor

HoKim98 commented Sep 25, 2022

I hope this calico typo correction commit will also be included in the next release!

@oomichi
Copy link
Contributor

oomichi commented Sep 26, 2022

I hope this calico typo correction commit will also be included in the next release!

That makes the parameter name change and might be user-facing change.
I wrote a release-note on the pull request.

@floryut
Copy link
Member Author

floryut commented Sep 26, 2022

And done 🥳

@rptaylor
Copy link
Contributor

rptaylor commented Jan 4, 2024

Looks like upgrading a cluster to 2.20 fails due to the calico block size change: #9055 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants