Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Ansible support for v2.9 and v2.10 #8925

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Drop Ansible support for v2.9 and v2.10 #8925

merged 1 commit into from
Jun 9, 2022

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented Jun 3, 2022 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Ansible v2.9 and v2.10 are EOL as 1.
This drops those version supports by following the upstream Ansible.

This sets use_ssh_args true always because that is required to use ssh_args on ansible.cfg on Ansible v2.11 or later2.

ansible_ssh_host is replaced with ansible_host because ansible_ssh_host has been deprecated already and cenots7 jobs were failed due to the deprecated ansible_ssh_host.

Does this PR introduce a user-facing change?:

Drop Ansible support for v2.9 and v2.10

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 3, 2022
@oomichi
Copy link
Contributor Author

oomichi commented Jun 3, 2022 •
edited
Loading

Necessary to rebase after #8922
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2022
@cristicalin cristicalin mentioned this pull request Jun 5, 2022
Closed
@cristicalin
Copy link
Contributor

@oomichi you will need to modify https://github.com/kubernetes-sigs/kubespray/blob/master/.gitlab-ci.yml#L37 to set it to 2.12 by default

@cristicalin cristicalin mentioned this pull request Jun 5, 2022
Merged
@oomichi
Copy link
Contributor Author

oomichi commented Jun 6, 2022

@oomichi you will need to modify https://github.com/kubernetes-sigs/kubespray/blob/master/.gitlab-ci.yml#L37 to set it to 2.12 by default

@cristicalin Thanks for pointing it out, I missed that.
OK, let me update the file also in this pull request.

@oomichi
Copy link
Contributor Author

oomichi commented Jun 6, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2022
@cristicalin
Copy link
Contributor

cristicalin commented Jun 6, 2022 •
edited
Loading

I see a pattern here in the sense that all centos7 jobs seem to fail, I triggered the manual ones as well. What I may suggest is to set ANSIBLE_VERSION=2.11 instead and see if the jobs pass.

@oomichi
Copy link
Contributor Author

oomichi commented Jun 6, 2022

I see a pattern here in the sense that all centos7 jobs seem to fail, I triggered the manual ones as well. What I may suggest is to set ANSIBLE_VERSION=2.11 instead and see if the jobs pass.

That seems a good try, let's do that.

oomichi
oomichi commented Jun 6, 2022
View reviewed changes
.gitlab-ci.yml Show resolved Hide resolved
@oomichi oomichi force-pushed the drop-older-ansibles branch 4 times, most recently from c1c8b37 to d587b2f Compare June 7, 2022 01:06
@oomichi
Copy link
Contributor Author

oomichi commented Jun 7, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2022
@oomichi oomichi force-pushed the drop-older-ansibles branch 4 times, most recently from 09ef2d3 to e93827b Compare June 7, 2022 18:50
@oomichi
Copy link
Contributor Author

oomichi commented Jun 7, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2022
@oomichi oomichi force-pushed the drop-older-ansibles branch 2 times, most recently from 3ab1d91 to ac9c4c5 Compare June 8, 2022 14:30
Drop Ansible support for v2.9 and v2.10
60c9969 
Ansible v2.9 and v2.10 are EOL as [1].
This drops those version supports by following the upstream Ansible.

This sets use_ssh_args true always because that is required to use
ssh_args on ansible.cfg on Ansible v2.11 or later[2].

ansible_ssh_host is replaced with ansible_host because ansible_ssh_host
has been deprecated already and cenots7 jobs were failed due to the
deprecated ansible_ssh_host.

[1]: https://docs.ansible.com/ansible/devel/reference_appendices/release_and_maintenance.html#ansible-core-changelogs
[2]: https://docs.ansible.com/ansible/latest/collections/ansible/posix/synchronize_module.html#parameter-use_ssh_args
@oomichi
Copy link
Contributor Author

oomichi commented Jun 8, 2022

@cristicalin Finally all necessary jobs are successful, please take a look again 😄

@cristicalin
Copy link
Contributor

Nice, we still have a version that goes back to ancient times (python 2.7 and old rhel7 boxes) while this lays the groundwork to move to 2.12 by default and opens up work for 2.13.

There is also this workaround that I think we can drop: https://github.com/kubernetes-sigs/kubespray/blob/master/roles/download/tasks/download_file.yml#L73-L77 (just the typecast to list) but that can be done in a cleanup later.

Thanks for the cleanup @oomichi

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit cd7381d into kubernetes-sigs:master Jun 9, 2022
@oomichi
Copy link
Contributor Author

oomichi commented Jun 9, 2022

Thanks for taking care of this @cristicalin

Nice, we still have a version that goes back to ancient times (python 2.7 and old rhel7 boxes) while this lays the groundwork to move to 2.12 by default and opens up work for 2.13.

There is also this workaround that I think we can drop: https://github.com/kubernetes-sigs/kubespray/blob/master/roles/download/tasks/download_file.yml#L73-L77 (just the typecast to list) but that can be done in a cleanup later.

That is a really nice point.
And when I tried to remove the above lines in download_file.yml, some jobs were failed.
Then I just kept the lines in this pull request to move forward.
It is nice to have another one to see what is the root problem.

@yankay yankay mentioned this pull request Jun 10, 2022
Merged
fungusakafungus pushed a commit to fungusakafungus/kubespray that referenced this pull request Jul 13, 2022
@oomichi @fungusakafungus
Drop Ansible support for v2.9 and v2.10 (kubernetes-sigs#8925)
c4b2d72 
Ansible v2.9 and v2.10 are EOL as [1].
This drops those version supports by following the upstream Ansible.

This sets use_ssh_args true always because that is required to use
ssh_args on ansible.cfg on Ansible v2.11 or later[2].

ansible_ssh_host is replaced with ansible_host because ansible_ssh_host
has been deprecated already and cenots7 jobs were failed due to the
deprecated ansible_ssh_host.

[1]: https://docs.ansible.com/ansible/devel/reference_appendices/release_and_maintenance.html#ansible-core-changelogs
[2]: https://docs.ansible.com/ansible/latest/collections/ansible/posix/synchronize_module.html#parameter-use_ssh_args
@floryut floryut mentioned this pull request Sep 19, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 1, 2023
@oomichi @LuckySB
Drop Ansible support for v2.9 and v2.10 (kubernetes-sigs#8925)
ca32dbb 
Ansible v2.9 and v2.10 are EOL as [1].
This drops those version supports by following the upstream Ansible.

This sets use_ssh_args true always because that is required to use
ssh_args on ansible.cfg on Ansible v2.11 or later[2].

ansible_ssh_host is replaced with ansible_host because ansible_ssh_host
has been deprecated already and cenots7 jobs were failed due to the
deprecated ansible_ssh_host.

[1]: https://docs.ansible.com/ansible/devel/reference_appendices/release_and_maintenance.html#ansible-core-changelogs
[2]: https://docs.ansible.com/ansible/latest/collections/ansible/posix/synchronize_module.html#parameter-use_ssh_args
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
@oomichi @LuckySB
Drop Ansible support for v2.9 and v2.10 (kubernetes-sigs#8925)
7acd878 
Ansible v2.9 and v2.10 are EOL as [1].
This drops those version supports by following the upstream Ansible.

This sets use_ssh_args true always because that is required to use
ssh_args on ansible.cfg on Ansible v2.11 or later[2].

ansible_ssh_host is replaced with ansible_host because ansible_ssh_host
has been deprecated already and cenots7 jobs were failed due to the
deprecated ansible_ssh_host.

[1]: https://docs.ansible.com/ansible/devel/reference_appendices/release_and_maintenance.html#ansible-core-changelogs
[2]: https://docs.ansible.com/ansible/latest/collections/ansible/posix/synchronize_module.html#parameter-use_ssh_args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristicalin cristicalin Awaiting requested review from cristicalin

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oomichi @k8s-ci-robot @cristicalin