-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore deleting worker nodes that are not in cluster #9244
Ignore deleting worker nodes that are not in cluster #9244
Conversation
Hi @kerryeon. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kerryeon Thanks!
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, kerryeon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Nice work! /lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
There is a bug that
remove-node.yml
tries to remove the worker nodes that are actually not in the cluster and emits an error.In fact, there have been several mechanisms to exclude 'ghost' nodes from deleting such as:
nodes
variable in https://github.com/kubernetes-sigs/kubespray/blob/master/roles/remove-node/pre-remove/tasks/main.yml#L18However, this implementation was not applied in the
post-remove
process, and this caused the process to eventually crash.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: