Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the updated (startup|liveness|readiness)Probe.Port numbers in Cilium #9031

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Add support for the updated (startup|liveness|readiness)Probe.Port numbers in Cilium #9031

merged 1 commit into from
Jun 27, 2022

Conversation

tomberget
Copy link
Contributor

@tomberget tomberget commented Jun 23, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:
In Cilium version 1.11.6 and above, they have changed the port number used for the (startup|liveness|readiness)Probes. This PR supports the change in port number for the newer versions, and makes sure that the older versions will be deployed using their port number.

Details on why the port changed can be found here: cilium/cilium#19830
Which issue(s) this PR fixes:

Fixes #9030

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[Cilium] Add support for the updated (startup|liveness|readiness)Probe.Port numbers

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 23, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @tomberget. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 23, 2022
@tomberget
Copy link
Contributor Author

/assign @Miouge1

@cristicalin
Copy link
Contributor

Thanks @tomberget !

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, Starefossen, tomberget

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2022
@oomichi
Copy link
Contributor

oomichi commented Jun 27, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit e1f06dd into kubernetes-sigs:master Jun 27, 2022
@tomberget tomberget deleted the feat/support_cilium_probe_ports branch June 28, 2022 07:34
@floryut floryut added kind/network Network section in the release note and removed kind/feature Categorizes issue or PR as related to a new feature. labels Jun 28, 2022
fungusakafungus pushed a commit to fungusakafungus/kubespray that referenced this pull request Jul 13, 2022
@floryut floryut mentioned this pull request Sep 19, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 2, 2023
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/network Network section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for the new Cilium *Probe ports from v1.11.6
7 participants