-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let containerd_default_runtime be undefined by default #9026
let containerd_default_runtime be undefined by default #9026
Conversation
Hi @rptaylor. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @rptaylor ! /ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, rptaylor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks! Looks like the CI test is failing for reasons related to the cloud resources ? @cristicalin |
/lgtm |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
See #9025
Which issue(s) this PR fixes:
Fixes #9025
Special notes for your reviewer:
The default filter is used so the only effect of this change will be to allow users to configure the variable in their inventory better. This is a better design pattern which is already used by other variables such as
containerd_snapshotter
.Does this PR introduce a user-facing change?:
No