Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ETCD_UNSUPPORTED_ARCH since etcdmain officially supports "arm64" #9049

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Remove ETCD_UNSUPPORTED_ARCH since etcdmain officially supports "arm64" #9049

merged 1 commit into from
Jul 4, 2022

Conversation

yankay
Copy link
Member

@yankay yankay commented Jul 1, 2022 •
edited by floryut
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Remove ETCD_UNSUPPORTED_ARCH since etcdmain officially supports "arm64"..

The etcd env ETCD_UNSUPPORTED_ARCH, and etcd args etcd-unsupported-arch in arm64 is no need anymore in etcd 3.5.x
( https://github.com/etcd-io/etcd/blob/v3.5.0/server/etcdmain/etcd.go#L468 )

Which issue(s) this PR fixes:

When 'etcd_deployment_type: kubeadm' the in arm64, it fails:

企业微信截图_16566728418447

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

remove the 'etcd-unsupported-arch' args to fix the etcd issue  in arm64

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 1, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @yankay. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2022
@liupeng0518
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2022
@yankay
Copy link
Member Author

yankay commented Jul 4, 2022

HI @cristicalin @floryut , would you please review the PR.

@floryut floryut added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 4, 2022
floryut
floryut approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yankay Nice, thanks 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1d0b382 into kubernetes-sigs:master Jul 4, 2022
@yankay
Copy link
Member Author

yankay commented Jul 4, 2022

Thank you @liupeng0518 @floryut for the PR review.

@floryut floryut removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 6, 2022
fungusakafungus pushed a commit to fungusakafungus/kubespray that referenced this pull request Jul 13, 2022
@yankay @fungusakafungus
remove-etcd-unsupported-arch (kubernetes-sigs#9049)
79a1c44
@yankay yankay mentioned this pull request Jul 22, 2022
Closed
9 tasks
@floryut floryut mentioned this pull request Sep 19, 2022
Closed
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@yankay @nolimitkun
remove-etcd-unsupported-arch (kubernetes-sigs#9049)
2a1180a
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 2, 2023
@yankay @LuckySB
remove-etcd-unsupported-arch (kubernetes-sigs#9049)
fdd5eeb
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
@yankay @LuckySB
remove-etcd-unsupported-arch (kubernetes-sigs#9049)
c8a130f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@EppO EppO Awaiting requested review from EppO

@jayonlau jayonlau Awaiting requested review from jayonlau

Assignees

@liupeng0518 liupeng0518

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yankay @k8s-ci-robot @liupeng0518 @floryut