Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[containerd] upgrade to 1.6.6 and add hashes #8980

Merged
merged 4 commits into from
Jun 17, 2022

Conversation

cristicalin
Copy link
Contributor

@cristicalin cristicalin commented Jun 15, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR adds the hashes for containerd versions 1.5.12, 1.5.13, 1.6.5 and 1.6.6 and makes 1.6.6 the new default. It also upgrades the nerdctl dependency to 0.20.0.

Which issue(s) this PR fixes:

Fixes #8984

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[containers] add hashes for 1.5.12, 1.5.13, 1.6.5 and 1.6.6, make 1.6.6 the new default
[nerdctl] upgrade to 0.20.0
[CI] test upgrade with defaults (containerd) instead of docker

@cristicalin cristicalin added the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Jun 15, 2022
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 15, 2022
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO June 15, 2022 09:29
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2022
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
🚀

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cristicalin,floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2022
# Docker specific settings:
container_manager: docker
etcd_deployment_type: docker
resolvconf_mode: docker_dns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job name contains docker.
If using the default containerd instead of docker, it is necessary to rename the job to remove docker.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh, I focused too much on getting the debian job running, will fix this as well and do another CI run

@oomichi
Copy link
Contributor

oomichi commented Jun 17, 2022

Thanks for fixing the ci issue also!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit 56d83c9 into kubernetes-sigs:master Jun 17, 2022
@floryut floryut mentioned this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version upgrade test is failing (packet_debian10-calico-upgrade)
4 participants